[CFT] UNIQUENAME patches

[Matthew Seaman]

On 17/06/2012 21:11, Mel Flynn wrote:
>>> >> I really don't see what the problem is with setting uniquename to:
>>> >> ${PORTORIGIN:S,/,__,}+${CHILDPORTNAME}
>>> >> or:
>>> >> databases/mysql55+server
>>> >> databases/mysql55+client
>>> >> etc.

>> > And so you want to forbid + as a character for PORTNAME? So you would need to
>> > fix all the ports having a + in the name.

> No. Ports all have a version starting with a minus sign, yet we have
> ports with a minus sign in it. This is the same principle. The plus or
> whatever char you pick, should be the first one from the right side
> after the version part. What's in between the plus and the start of
> version is subpackage/childport name.

Deciding what character or characters to use to distinguish the sub-port
part of the package name from the rest is a particularly bikeshedable
point.  Virtually any of the punctuation on the keyboard could be used,
and it really won't make much difference in the end what gets chosen.
Personally I feel it should be the sole choice of the people that do the
work to implement sub-ports.

On the point of how UNIQUENAME should be defined, your arguments have
some merit, but I'm not convinced.  On balance, after considering such
points I preferred what I came up with (but then I would say that,
wouldn't I?)

	Cheers,

	Matthew

-- 
Dr Matthew J Seaman MA, D.Phil.
PGP: http://www.infracaninophile.co.uk/pgpkey




-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 267 bytes
Desc: OpenPGP digital signature
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20120618/11ba4252/signature.pgp