graphics/libfpx: use of bsd.lib.mk and warnings

[Thomas Zander]

On Sat, Jul 28, 2012 at 6:28 PM, Andriy Gapon <avg at freebsd.org> wrote:
> Does it fail to build with clang?

Yes:

clang++ -fpic -DPIC  -O2 -pipe -DHAVE_WCHAR_H -DHAVE_DLFCN_H
-DHAVE_SYS_TIME_H -DHAVE_SYS_PARAM_H -DHAVE_SYS_MOUNT_H
-Qunused-arguments -fstack-protector -Werror -Wall -Wno-format-y2k -W
-Wno-unused-parameter -Wpointer-arith -Wno-uninitialized
-Wno-empty-body -Wno-string-plus-int -Wno-tautological-compare
-Wno-unused-value -Wno-parentheses-equality -Wno-unused-function
-Wno-conversion -fno-rtti -fno-exceptions -fno-strict-aliasing
-DHAVE_WCHAR_H -DHAVE_DLFCN_H -DHAVE_SYS_TIME_H -DHAVE_SYS_PARAM_H
-DHAVE_SYS_MOUNT_H
-I/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/oless/h
-I/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/jpeg
-I/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/ole
-I/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/basics
-I/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/ri_image
-I/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/oless
-I/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/fpx
-I/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/.
-I/usr/local/include -D_UNIX -c
/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/ri_image/pr_level.cpp
-o pr_level.So
In file included from
/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/ri_image/viewimg.cpp:49:
/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/fpx/f_fpxio.h:146:31:
error: 'PFileFlashPixIO::CreateEmptyResolutionLevel' hides overloaded
virtual function [-Werror,-Woverloaded-virtual]
    virtual PResolutionLevel* CreateEmptyResolutionLevel(int width,
int height, int* whichImage);  // Make a sub image in create mode
                              ^
/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/ri_image/ph_image.h:175:31:
note: hidden overloaded virtual function
'PHierarchicalImage::CreateEmptyResolutionLevel' declared here
    virtual PResolutionLevel* CreateEmptyResolutionLevel(int width,
int height, long* quelImage); // Make a sub image in create mode
                              ^
In file included from
/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/ri_image/viewimg.cpp:49:
/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/fpx/f_fpxio.h:146:31:
error: 'PFileFlashPixIO::CreateEmptyResolutionLevel' hides overloaded
virtual function [-Werror,-Woverloaded-virtual]
    virtual PResolutionLevel* CreateEmptyResolutionLevel(int width,
int height, int* whichImage);  // Make a sub image in create mode
                              ^
/usr/portbuild/usr/ports/graphics/libfpx/work/libfpx-1.2.0.12/ri_image/ph_image.h:175:31:
note: hidden overloaded virtual function
'PHierarchicalImage::CreateEmptyResolutionLevel' declared here
    virtual PResolutionLevel* CreateEmptyResolutionLevel(int width,
int height, long* quelImage); // Make a sub image in create mode
                              ^
1 error generated.
*** [viewimg.So] Error code 1
1 error generated.
*** [viewimg.o] Error code 1
2 errors
*** [do-build] Error code 1

Stop in /usr/ports/graphics/libfpx.


In any case, a port should not pick up CC or CXX definitions from /etc/src.conf.
Riggs