Question about new options framework (regression?)

[Oliver Fromme]

Jase Thew wrote:
 > On 27/07/2012 10:41, Baptiste Daroussin wrote:
 > > 
 > > I think that is the more reasonnable, I'll add this when fully back. I was
 > > thinking of LATE_SET and LATE_UNSET but OVERRIDE_SET and OVERRIDE_UNSET sounds
 > > better to me.
 > 
 > What use-case are you thinking of that requires the ability for saved
 > config to override manually specified config? If there isn't a
 > compelling reason for this, then I'd personally much rather see the
 > original behaviour restored rather than adding another two variables.

Baptiste is right ...  The original behaviour is flawed,
because it depends on how the port's maintainer wrote the
Makefile.

For example, If you have WITH_FOO=YES in the options file,
and the port's Makefile checks whether WITH_FOO is set or
unset, then there is *no* way to override that, not even
with the old options framework.

In the case of zsh I was lucky, because the (old) Makefile
checked if WITH_ZSH_STATIC is set, while the options file
contained WITHOUT_ZSH_STATIC, so I could override that.
If it was checking whether WITHOUT_ZSH_STATIC was unset,
it wouldn't have worked.

Also, if I wanted to do it the other way round, i.e. set
WITH_ZSH_STATIC in the options file, there would be no
way to unset that on the command line.

So, Baptiste's approach to fix that alltogether is right,
in my opinion.

Best regards
   Oliver


-- 
Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M.
Handelsregister: Registergericht Muenchen, HRA 74606,  Geschäftsfuehrung:
secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mün-
chen, HRB 125758,  Geschäftsführer: Maik Bachmann, Olaf Erb, Ralf Gebhart

FreeBSD-Dienstleistungen, -Produkte und mehr:  http://www.secnetix.de/bsd

 > Can the denizens of this group enlighten me about what the
 > advantages of Python are, versus Perl ?
"python" is more likely to pass unharmed through your spelling
checker than "perl".
        -- An unknown poster and Fredrik Lundh