[RFC] LibreOffice build issues

[Andriy Gapon]

on 26/07/2012 03:31 Jung-uk Kim said the following:
> I guess you had installed OpenSSL from ports. ;-)

Yes, bingo.

> Now I am able to build it with GCC 4.6:
> 
> http://people.freebsd.org/~jkim/libreoffice-20120725.tar.bz2
> 
> Basically, bsd.openssl.mk adds -rpath=/usr/lib:/usr/local/lib to
> LDFLAGS first, then bsd.gcc.mk adds -Wl,-rpath=/usr/local/lib/gcc46 to
> it later.
> 
> Before:
> % make -V LDFLAGS
>  -rpath=/usr/lib:/usr/local/lib
> % make -V LDFLAGS USE_OPENSSL_BASE=yes
>  -rpath=/usr/lib:/usr/local/lib
> % make -V LDFLAGS USE_OPENSSL_PORT=yes
>  -rpath=/usr/local/lib
> % make -V LDFLAGS USE_OPENSSL_BASE=yes WITH_GCC=yes
>  -rpath=/usr/lib:/usr/local/lib -Wl,-rpath=/usr/local/lib/gcc46
> % make -V LDFLAGS USE_OPENSSL_PORT=yes WITH_GCC=yes
>  -rpath=/usr/local/lib -Wl,-rpath=/usr/local/lib/gcc46
> 
> For WITH_GCC case, I just defined OPENSSL_LDFLAGS as
> "-rpath=/usr/local/lib/gcc46".
> 
> After:
> % make -V LDFLAGS
>  -rpath=/usr/lib:/usr/local/lib
> % make -V LDFLAGS USE_OPENSSL_BASE=yes
>  -rpath=/usr/lib:/usr/local/lib
> % make -V LDFLAGS USE_OPENSSL_PORT=yes
>  -rpath=/usr/local/lib
> % make -V LDFLAGS USE_OPENSSL_BASE=yes WITH_GCC=yes
>  -rpath=/usr/local/lib/gcc46 -rpath=/usr/lib:/usr/local/lib
> -Wl,-rpath=/usr/local/lib/gcc46
> % make -V LDFLAGS USE_OPENSSL_PORT=yes WITH_GCC=yes
>  -rpath=/usr/local/lib/gcc46 -rpath=/usr/local/lib
> -Wl,-rpath=/usr/local/lib/gcc46
> 
> It's ugly but it's good enough for now.
> 
> Please note this is really a bug in bsd.openssl.mk (and/or bsd.port.mk
> depending on how you look at it).  It shouldn't have added /usr/lib in
> the first place.  It is only needed for OPENSSL_PORT case and just
> /usr/local/lib itself.  Also, bsd.gcc.mk had to be included before all
> bsd.foo.mk, whatever touches rpath.

Good analysis and catch!
I think that just dropping /usr/lib from rpath should be sufficient, but the way
you are doing it could be safer in the long term.
Thank you.

-- 
Andriy Gapon