Please test your commits

[Doug Barton]

On 02/17/2012 10:22, Mark Linimon wrote:
> On Sun, Feb 12, 2012 at 08:35:05PM +0000, Michael Scheidell wrote:
>> Public flogging seems to be more enjoyable than a private email to the
>> developer, the maintainer, and a committer.
> 
> I know we are all a little frustrated with some of the local commits, but
> remember:
> 
>   "praise in public, criticize in private".

I agree that "praise in public" is a maxim. I think we can also agree
that all forms of "$person has had a lot of 'issues,' can portmgr assign
some remediation here?" should be private.

Where I think reasonable minds can differ are (appropriate) responses of
the form, "This was not done properly, here is how it can/should be done
(better)." IMO those should *always* be public in order to help others
who are paying attention to the same topic. By not making these things
public all we do is create a cycle developer after developer doing it
wrong because the right way was never made obvious to them.

(And no, good documentation is not enough. Just look at how many times
I've had to repeat the same (basic) points about rc.d scripts.)


Doug

-- 

	It's always a long day; 86400 doesn't fit into a short.

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/