Making 8.3 packaged ports 'pretty'... and INSTALL_ICONS macro.

[Oliver Heesakkers]

Op do 16 feb 2012 07:54:23 schreef Michael Scheidell:
> In looking at some of the prs, minor ones, (safe ones) which just
> upgrades, I noticed one that is a kde4/q4t program,
> portlint complains (a little)
> 
> WARN: deskutils/plasma-applet-cwp/pkg-plist: [36]: installing icons,
> please define INSTALLS_ICONS as appropriate
> WARN: deskutils/plasma-applet-cwp/pkg-plist: [37]: installing icons,
> please define INSTALLS_ICONS as appropriate
> 
> putting in INSTALLS_ICONS=yes in Makefile, keeps it quiet, but what are
> the side affects of this? does it affect pkg-plist, does it affect 'non
> gnome' programs?
> 
> a nice, quiet portline is fine, but not if it changes the port.
> 

You committed the patch I wrote in ports/164344.

.if exists(${LOCALBASE}/bin/gnome-session)
INSTALLS_ICONS=        yes
.endif

Even with that patch 'portlint -a' still complains the way you describe it. 
Perhaps portlint could use some fine-tuning in this regard.

I started this thread on the kde-freebsd mailinglist:
http://mail.kde.org/pipermail/kde-freebsd/2012-January/012306.html