Please test your commits

[Andriy Gapon]

on 12/02/2012 22:45 Stephen Montgomery-Smith said the following:
> On 02/12/2012 02:41 PM, Steve Kargl wrote:
>> On Sun, Feb 12, 2012 at 10:27:25PM +0200, Andriy Gapon wrote:
>>> on 12/02/2012 22:16 Steve Kargl said the following:
>>>> You seem to have the faulty belief that this is the first occurence
>>>> of this type of issue?
>>>
>>> So instead of proper report to the port's maintainer (including description of
>>> your environment, possibly full build log, etc), possibly with a CC here, you
>>> decided to vent out here...
>>>
>>> Is there any requirement that people do the former and not the latter? :-)
>>>
>>
>> I'm not venting.  I'm simply requesting that all committers
>> test the code that they intend to commit.  It is quite
>> clear that this particular commit was not tested.
>>
>> The environment is irrelevant because malloc.h was poisoned
>> 10 years, 3 months ago.  As to a full build log, the
>> necessary information was included in my original email.
> 
> Except I didn't get the malloc.h error when I tried compiling it.  So merely
> noting the age of malloc.h doesn't prove that the committer didn't test it.

Today I became another user of redports.org.  I can definitely recommend it.

-- 
Andriy Gapon