Please test your commits

[Chris Rees]

On 12 Feb 2012 20:45, "Steve Kargl" <sgk at troutmask.apl.washington.edu>
wrote:
>
> On Sun, Feb 12, 2012 at 08:44:11PM +0000, Chris Rees wrote:
> > On 12 Feb 2012 20:41, "Steve Kargl" <sgk at troutmask.apl.washington.edu>
> > wrote:
> > >
> > > On Sun, Feb 12, 2012 at 10:27:25PM +0200, Andriy Gapon wrote:
> > > > on 12/02/2012 22:16 Steve Kargl said the following:
> > > > > You seem to have the faulty belief that this is the first
occurence
> > > > > of this type of issue?
> > > >
> > > > So instead of proper report to the port's maintainer (including
> > description of
> > > > your environment, possibly full build log, etc), possibly with a CC
> > here, you
> > > > decided to vent out here...
> > > >
> > > > Is there any requirement that people do the former and not the
latter?
> > :-)
> > > >
> > >
> > > I'm not venting.  I'm simply requesting that all committers
> > > test the code that they intend to commit.  It is quite
> > > clear that this particular commit was not tested.
> > >
> > > The environment is irrelevant because malloc.h was poisoned
> > > 10 years, 3 months ago.  As to a full build log, the
> > > necessary information was included in my original email.
> >
> > uname -a?
> >
> > Please do this the proper way; as a developer yourself you should know
> > better.
> >
>
> laptop:root[252]  uname -a
> FreeBSD laptop 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r230975M: Sat Feb  4
09:03:27 PST 2012     root at laptop:/usr/obj/usr/src/sys/MOBILE  i386

Well, that immediately shows that this is a 10.0 error, which means it's
almost certainly due to freebsd1* being matched in some configure script.

This was not a case of zero testing, so please submit a PR.

Chris