Please test your commits

[Steve Kargl]

On Sun, Feb 12, 2012 at 08:03:28PM +0000, Chris Rees wrote:
> On 12 Feb 2012 19:39, "Steve Kargl" <sgk at troutmask.apl.washington.edu>
> wrote:
> >
> > Is there any reguirement that a ports committer needs
> > to test their intended commit prior to pulling the
> > trigger?
> >
> 
> Could this not have gone directly to the 'offending' developer?
> 

You seem to have the faulty belief that this is the first occurence
of this type of issue?

portmgr should immediately revert the commit.

In fact, after changing the source code to avoid the malloc.h
issue, one runs into

cp ./soobj/openjpeg_0.dev ./soobj/openjpeg.dev
cc  -DHAVE_MKSTEMP   -DHAVE_FONTCONFIG -DHAVE_LIBIDN -DHAVE_SETLOCALE -DHAVE_SSE2 -DHAVE_DBUS   -O2 -pipe -march=native -fno-strict-aliasing -g -fPIC -DUPD_SIGNAL=0 -I.  -I/usr/ports/print/ghostscript9/work/ghostscript-9.05/lcms/include  -I/usr/local/include/libpng  -I/usr/local/include -I/usr/local/include/freetype2  -Wall -Wstrict-prototypes -Wundef -Wmissing-declarations -Wmissing-prototypes -Wwrite-strings -Wno-strict-aliasing -Wdeclaration-after-statement -fno-builtin -fno-common -DHAVE_STDINT_H=1 -DHAVE_SYS_TIME_H=1 -DGX_COLOR_INDEX_TYPE="unsigned long long" -O2 -pipe -march=native -fno-strict-aliasing -DUSE_LIBICONV_GNU -I/usr/local/include   -DGS_DEVS_SHARED -DGS_DEVS_SHARED_DIR=\"/usr/local/lib/ghostscript/9.05\"  -Iopenjpeg/libopenjpeg/.. -Iopenjpeg/libopenjpeg -I./soobj -I./base -DUSE_OPENJPEG_JP2  -o ./soobj/sjpx_openjpeg.o \
        -c -DOPJ_STATIC ./base/sjpx_openjpeg.c
./base/sjpx_openjpeg.c: In function 'decode_image':
./base/sjpx_openjpeg.c:169: error: too many arguments to function 'opj_decode'
./base/sjpx_openjpeg.c:205: error: 'opj_image_comp_t' has no member named 'typ'
./base/sjpx_openjpeg.c:205: error: 'CTYPE_COLOR' undeclared (first use in this function)
./base/sjpx_openjpeg.c:205: error: (Each undeclared identifier is reported only once
./base/sjpx_openjpeg.c:205: error: for each function it appears in.)
./base/sjpx_openjpeg.c:207: error: 'opj_image_comp_t' has no member named 'typ'
./base/sjpx_openjpeg.c:207: error: 'CTYPE_OPACITY' undeclared (first use in this function)
./base/sjpx_openjpeg.c:217: error: 'CLRSPC_CMYK' undeclared (first use in this function)
./base/sjpx_openjpeg.c:250: error: 'opj_image_t' has no member named 'has_palette'
./base/sjpx_openjpeg.c:257: error: 'CLRSPC_EYCC' undeclared (first use in this function)
gmake[2]: *** [soobj/sjpx_openjpeg.o] Error 1
gmake[2]: Leaving directory `/usr/ports/print/ghostscript9/work/ghostscript-9.05'
gmake[1]: *** [so-subtarget] Error 2
gmake[1]: Leaving directory `/usr/ports/print/ghostscript9/work/ghostscript-9.05'
gmake: *** [so] Error 2

-- 
Steve