Preferred way of applying OSVERSION-dependend patches

Ruslan Mahmatkhanov cvs-src at yandex.ru
Sun Apr 1 10:02:41 UTC 2012


Good day!

What is a preferred way of doing subj?

1. Add an extra-patch-* to files/ subdirectory and apply it depending
    of checks in Makefile (.if ${OSVERSION}).
2. Add an patch-* to files subdirectory that applies unconditionally
    and that checking for __FreeBSD_version in app code itself.

The second one will guarantee that the patch still applies cleanly on 
port versions update, but it will make it more hard to find conditional 
checks for obsoleted FreeBSD versions (because most people, I believe, 
only looking to Makefile for things like this).

Thanks.

-- 
Regards,
Ruslan

Tinderboxing kills... the drives.


More information about the freebsd-ports mailing list