audio/cdparanoia broken on -CURRENT, and probably on 9.0

[Kenneth D. Merry]

On Fri, Oct 07, 2011 at 03:46:22 -0400, b. f. wrote:
> Just a note to say that recent changes on -CURRENT (r225950, meaning
> that it is probably broken on 9.0 after r226067) have broken
> audio/cdparanoia, and it should be fixed or marked as BROKEN there.  I
> haven't filed a PR, or attempted to patch it yet -- I think that it
> would be worthwhile to look into moving to 10.2, which has a large
> number of improvements, although suffering from some Linuxisms.

This will be easy to patch, using one of two methods:

 - change struct scsi_sense_data to struct scsi_sense_data_fixed
or, better yet:
 - use scsi_extract_sense_len(), which will work for fixed or descriptor
   sense.

> Regards,
>                 b.
> 
> 
> ===>   cdparanoia-3.9.8_9 depends on executable: gmake - found
> ===>  Configuring for cdparanoia-3.9.8_9
> creating cache ./config.cache
> checking host system type... Invalid configuration
> `amd64-portbld-freebsd9.9': machine `amd64-portbld' not recognized
> 
> checking for ranlib... ranlib
> checking for ar... ar
> checking for install... /usr/bin/install -c -o root -g wheel
> checking how to run the C preprocessor... cpp
> checking for ANSI C header files... yes
> checking size of short... 2
> checking size of int... 4
> checking size of long... 8
> checking size of long long... 8
> checking for int16_t... yes
> checking for int32_t... yes
> checking for u_int16_t... yes
> checking for u_int32_t... yes
> checking for linux/sbpcd.h... no
> checking for linux/ucdrom.h... no
> checking whether gmake sets ${MAKE}... yes
> checking for working const... yes
> updating cache ./config.cache
> creating ./config.status
> creating Makefile
> creating interface/Makefile
> creating paranoia/Makefile
> ===>  Building for cdparanoia-3.9.8_9
> cd interface && gmake all
> gmake[1]: Entering directory
> `/tmp/home/u1/pwrk/ports/audio/cdparanoia/work/cdparanoia-III-alpha9.8/interface'
> gmake libcdda_interface.a CFLAGS="-O -O2 -pipe -march=athlon64
> -fno-strict-aliasing"
> gmake[2]: Entering directory
> `/tmp/home/u1/pwrk/ports/audio/cdparanoia/work/cdparanoia-III-alpha9.8/interface'
> cc -O -O2 -pipe -march=athlon64 -fno-strict-aliasing -c scan_devices.c
> cc -O -O2 -pipe -march=athlon64 -fno-strict-aliasing -c common_interface.c
> cc -O -O2 -pipe -march=athlon64 -fno-strict-aliasing -c cooked_interface.c
> cc -O -O2 -pipe -march=athlon64 -fno-strict-aliasing -c interface.c
> cc -O -O2 -pipe -march=athlon64 -fno-strict-aliasing -c scsi_interface.c
> scsi_interface.c: In function 'handle_scsi_cmd':
> scsi_interface.c:370: error: 'struct scsi_sense_data' has no member
> named 'flags'
> scsi_interface.c:381: error: 'struct scsi_sense_data' has no member
> named 'add_sense_code'
> scsi_interface.c:382: error: 'struct scsi_sense_data' has no member
> named 'add_sense_code_qual'
> scsi_interface.c: In function 'scsi_read_map':
> scsi_interface.c:967: error: 'struct scsi_sense_data' has no member
> named 'flags'
> scsi_interface.c:968: error: 'struct scsi_sense_data' has no member
> named 'add_sense_code'
> scsi_interface.c:969: error: 'struct scsi_sense_data' has no member
> named 'add_sense_code_qual'
> gmake[2]: *** [scsi_interface.o] Error 1
> gmake[2]: Leaving directory
> `/tmp/home/u1/pwrk/ports/audio/cdparanoia/work/cdparanoia-III-alpha9.8/interface'
> gmake[1]: *** [all] Error 2
> gmake[1]: Leaving directory
> `/tmp/home/u1/pwrk/ports/audio/cdparanoia/work/cdparanoia-III-alpha9.8/interface'
> gmake: *** [all] Error 2
> *** Error code 1
> 
> Stop in /home/u1/pwrk/ports/audio/cdparanoia.

Ken
-- 
Kenneth Merry
ken at FreeBSD.ORG