is %%GECKO%% defined anywhere?

Test Rat ttsestt at gmail.com
Wed Jul 27 13:06:10 UTC 2011


Anton Shterenlikht <mexas at bristol.ac.uk> writes:

> On Wed, Jul 27, 2011 at 03:14:57PM +0400, Test Rat wrote:
>> Anton Shterenlikht <mexas at bristol.ac.uk> writes:
>> 
>> [...]
>> > HOw about doing away with gecko.sh
>> > completely, and letting the user
>> > specify what they want directly in
>> > $HOME/.urlview:
>> >
>> > % cat $HOME/.urlview
>> > COMMAND lynx %s
>> > #COMMAND firefox3 %s
>> > #COMMAND midori %s
>> 
>> Then we don't need url_handler.sh as well. But I don't use
>> the port... it's redundant when one has browse-url-at-point. ;)
>
> Thanks for the patch. I like it.
> But this seems like a major change.
> What's the usual consultation
> procedure and period for changes like this?

This is usually done at the discretion of maintainer
with a note in UPDATING. As for the patch it probably
needs more examples (and exposure), e.g.

  COMMAND lynx %s                            # :VT
  COMMAND u=%s; xterm -e lynx $u || lynx $u  # :XT
  COMMAND firefox %s 2>/dev/null &           # :XW

when 2nd one shows how to cycle between multiple commands.
As system(3) invokes sh(1) the syntax is same except %s can
only appear once (at least without patching urlview.c).

FWIW, some unreachable cruft can probably pruned while here.
I'm not sure if any FreeBSD mirrors still have that urlview.diff
but the file doesn't appear on archive.org.

%%
Index: textproc/urlview/Makefile
===================================================================
RCS file: /a/.cvsup/ports/textproc/urlview/Makefile,v
retrieving revision 1.33
diff -u -p -r1.33 Makefile
--- textproc/urlview/Makefile	2 May 2011 22:05:18 -0000	1.33
+++ textproc/urlview/Makefile	27 Jul 2011 12:44:01 -0000
@@ -14,9 +14,6 @@
 		ftp://ftp.sunsite.auc.dk/pub/mail/mutt/contrib/ \
 		ftp://ftp.cs.tu-berlin.de/pub/net/mail/mutt/contrib/
 
-#PATCH_SITES=	http://feeding.frenzy.com/~rainking/
-#PATCHFILES=	urlview.diff
-
 MAINTAINER=	mexas at bristol.ac.uk
 COMMENT=	URL extractor/launcher
 
%%


More information about the freebsd-ports mailing list