[RFC] A trivial change for DESKTOP_ENTRIES (take 2)

[Warren Block]

On Fri, 15 Jul 2011, Scot Hetzel wrote:

> 2011/7/14 Pav Lucistnik <pav at freebsd.org>:
>> Stephen Montgomery-Smith píše v čt 14. 07. 2011 v 11:57 -0500:
>>
>>> entry.  I assume that the filename of the desktop entry is unimportant,
>>
>> The filename of desktop entry should be 100% inconsequential, and our
>> only care should be not have two ports installing same file.
>>
>>> and is used only internally by Gnome or whatever.
>>
>> Sounds like a bug to me.
>>
>>> But maybe it would have been better to have had one more entry in
>>> DESKTOP_ENTRIES that was the actual filename of the desktop entry.
>>
>> Yes, but is it worth the effort? Note you'll have to introduce it
>> somehow not to break existing ports.
>>
>
> How about something like this:
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=158936

Wouldn't the point of using a separate filename argument be to let the 
user specify exactly what the name is?  Here you end up with the same 
system-processed filename.  Possibly I've misunderstood.

Apart from whether it's necessary, making the filename the last field 
would simplify the code.  Just .if defined(DESKTOP_ENTRIES) or 
defined(DESKTOP_ENTRIESv2) at the start of parameter processing, and a 
.if defined(DESKTOP_ENTRIESv2) section after it to override the 
filename.  It could also be made polymorphic, basing what it does on the 
number of fields rather than a new DESKTOP_ENTRIESv2 define.