[RFC] A trivial change for DESKTOP_ENTRIES
Jung-uk Kim
jkim at FreeBSD.org
Wed Jul 13 17:23:54 UTC 2011
On Wednesday 13 July 2011 01:04 pm, Stephen Montgomery-Smith wrote:
> On 07/13/2011 11:59 AM, Stephen Montgomery-Smith wrote:
> > But code like this seems simpler than my original suggestion:
> >
> > if (echo "$$4" | grep -E [^[:alnum:]_-]> /dev/null); then echo \
> > ${ECHO_MSG} "blah blah."; \
> > exit 1; \
> > fi; \
> > pathname="${DESKTOPDIR}/$$4";
>
> Oh, and use ${GREP} and ${ECHO_CMD} instead of echo and grep. And
> maybe the "-E" is unnecessary.
If we actually do "exit 1;", I'd prefer something like that, too.
Jung-uk Kim
More information about the freebsd-ports
mailing list