[RFC] A trivial change for DESKTOP_ENTRIES

Pav Lucistnik pav at FreeBSD.org
Wed Jul 13 11:59:02 UTC 2011


On 2011/07/13 00:25, Jung-uk Kim wrote:
> After I updated x11-wm/compiz, GNOME was not able to start the window
> manager.  Basically, it complained that compiz-manager was not found.
> Then, I realized compiz-manager.desktop was automagically replaced by
> compizmanager.desktop.  Now I tracked it down to this commit:
>
> Sat Nov 27 17:42:46 2010 UTC (7 months, 2 weeks ago) by pav
>
> - DESKTOP_ENTRIES: commandline is used to name installed .desktop
> file, this can lead to files containing whitespace and funny
> characters; thus strip all non-alphanumeric characters
>
> http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.port.mk.diff?r1=1.656;r2=1.657
>
> To me, it looks far too restrictive.  At least, I'd like to allow '-'
> and '_'.  Please see the attached patch.
>
> Any objections?

Shouldn't you fix whatever is trying to call compizmanager not to use 
.desktop file instead?

-- 
Pav Lucistnik <pav at oook.cz>
               <pav at FreeBSD.org>


More information about the freebsd-ports mailing list