failed bsd.qt.mk fix...

Oliver Pinter oliver.pntr at gmail.com
Fri Jul 1 21:25:09 UTC 2011


The original (commited patch in ports) is not my patch. I only wrote a
fixup to make it usable, after avillas commit breaked the ports.

On 7/1/11, Rene Ladan <rene at freebsd.org> wrote:
> Op 01-07-2011 20:54, Oliver Pinter schreef:
>> On 7/1/11, Oliver Pinter <oliver.pntr at gmail.com> wrote:
>>> after reverting this:
>>> http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.qt.mk.diff?r1=1.24;r2=1.25
>>> everything look fine..
>>
>> or use this patch:
>>
>> op at pandora-d ~> less /tmp/diff
>> --- bsd.qt.mk   2011-07-01 20:53:32.000000000 +0200
>> +++ bsd.qt.mk-op        2011-07-01 20:52:48.000000000 +0200
>> @@ -112,7 +112,7 @@
>>  #
>>  # Translate `c++` to its real name and select the appropriate mkspec.
>>  #
>> -QMAKE_BASE_COMPILER!=  cc --version 2> /dev/null | awk 'NR == 1 {
>> gsub(/[()]/, "", $2); print $2 }'
>> +QMAKE_BASE_COMPILER!=  cc --version 2> /dev/null | awk 'NR == 1 {
>> gsub(/[()]/, "", $$2); print $$2 }'
>>  .if ${QMAKE_BASE_COMPILER:L} == "gcc"
>>  QMAKE_BASE_COMPILER=   g++
>>  .endif
>
> Wouldn't it be better to use ${CC} instead of cc in the above patch so
> that clang is also (a bit more) supported?
> --
> http://www.rene-ladan.nl:8080/
>
> GPG fingerprint = ADBC ECCD EB5F A6B4 549F  600D 8C9E 647A E564 2BFC
> (subkeys.pgp.net)
>

The original (commited patch in ports) is not my patch. I only wrote a
fixup to make it usable, after avillas commit breaked the ports.


More information about the freebsd-ports mailing list