Request for new port review: TortoiseHG.

[Koop Mast]

On Thu, 2011-02-10 at 18:21 +0300, arrowdodger wrote:
> On Thu, Feb 10, 2011 at 5:35 PM, Sunpoet Po-Chuan Hsieh <sunpoet at freebsd.org
> > wrote:
> 
> > On Thu, Feb 10, 2011 at 04:36:40PM +0300, arrowdodger wrote:
> > > I've updated port. The only thing left - setting dependency on py-gobject
> > by
> > > USE_GNOME variable.
> > > But if i run pkg_info -f on installed port, i see:
> > >
> > > > Dependency: py26-gobject-2.26.0
> > > >         dependency origin: devel/py-gobject
> > > >
> > > So, maybe this dependency is implicit and i should not care?
> >
> > Obviously USE_GNOME does not support devel/py-gobject now. All you can
> > do is to use BUILD_DEPENDS/RUN_DEPENDS.

There is now a pygobject USE_GNOME switch.

-Koop

> > Your pkg_info result indicates that you've installed gobject, but it
> > means nothing to users of this port. The ports infrastructure generates
> > dependency list according to the Makefile. If py-gobject is required,
> > add it to the corresponding *_DEPENDS explicitly. Otherwise gobject will
> > not be installed.
> >
> > > Updated port can be obtained here:
> > > http://intara.org.ru/tortoisehg1.shar
> > > or from attachment.
> >
> > Some comments:
> > - PORTNAME can be different with the path. PORTNAME=tortoisehg is OK.
> > - We usually use "USE_PYTHON=yes"
> > - It would be better to keep patches in *-patch: targets.
> >  Move "${REINPLACE_CMD}" actions to post-patch:.
> > - If this port does not need to run configure or so. Use
> > do-configure:
> >        @${DO_NADA}
> >
> > Regards,
> >
> Done.
> 
> How should i submit new port? Open an PR?
> _______________________________________________
> freebsd-ports at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscribe at freebsd.org"