Request for new port review: TortoiseHG.

[Sunpoet Po-Chuan Hsieh]

On Thu, Feb 10, 2011 at 04:36:40PM +0300, arrowdodger wrote:
> I've updated port. The only thing left - setting dependency on py-gobject by
> USE_GNOME variable.
> But if i run pkg_info -f on installed port, i see:
> 
> > Dependency: py26-gobject-2.26.0
> >         dependency origin: devel/py-gobject
> >
> So, maybe this dependency is implicit and i should not care?

Obviously USE_GNOME does not support devel/py-gobject now. All you can
do is to use BUILD_DEPENDS/RUN_DEPENDS.

Your pkg_info result indicates that you've installed gobject, but it
means nothing to users of this port. The ports infrastructure generates
dependency list according to the Makefile. If py-gobject is required,
add it to the corresponding *_DEPENDS explicitly. Otherwise gobject will
not be installed.

> Updated port can be obtained here:
> http://intara.org.ru/tortoisehg1.shar
> or from attachment.

Some comments:
- PORTNAME can be different with the path. PORTNAME=tortoisehg is OK.
- We usually use "USE_PYTHON=yes"
- It would be better to keep patches in *-patch: targets.
  Move "${REINPLACE_CMD}" actions to post-patch:.
- If this port does not need to run configure or so. Use
do-configure:
	@${DO_NADA}

Regards,
-- 
   Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net> <sunpoet at FreeBSD.org>
           4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B
	                     http://people.FreeBSD.org/~sunpoet/pgpkeys.txt