Request for new port review: TortoiseHG.

Sunpoet Hsieh sunpoet at sunpoet.net
Wed Feb 9 16:09:32 UTC 2011


On Wed, Feb 09, 2011 at 06:24:34PM +0300, arrowdodger wrote:
> On Wed, Feb 9, 2011 at 4:42 PM, Sunpoet Hsieh <sunpoet at sunpoet.net> wrote:
> 
> > It looks like you'll have two ports, version 1 and 2, and these two
> > ports do not conflict with each other.
> > IMHO, I would simply use devel/tortoisehg1 for version 1 and
> > devel/tortoisehg for upcoming version 2.
> > You do not need to add -gtk or -pyqt suffix to emphasize the use of GTK or
> > Qt.
> >
> Okay.
> 
> Now regarding this:
> 
> > >> In your case, it can be done without extra patch files.
> > >>
> > >> .if !defined(WITH_NAUTILUS)
> > >>        @${REINPLACE_CMD} -e '153,154 D' ${WRKSRC}/${PYSETUP}
> > >> .endif
> > >> .if !defined(WITH_NLS)
> > >>        @${REINPLACE_CMD} -e '150,152 D' ${WRKSRC}/${PYSETUP}
> > >> .endif
> >
> -e 'x,y D' removes whole line, so all lines under removed line get shifted.
> So, it's impossible to apply them in all combinations.
> I'm not familiar with sed, but is it possible to delete whole line, but
> leave \n at the end so line numbers will not be shifted?

You're right.
I'll use @${REINPLACE_CMD} -e '153,154 s|^|# |' ${WRKSRC}/${PYSETUP} instead.

> PYDISTUTILS_EGGINFO defaults to
> >
> > ${PYDISTUTILS_PKGNAME:C/[^A-Za-z0-9.]+/_/g}-${PYDISTUTILS_PKGVERSION:C/[^A-Za-z0-9.]+/_/g}-${PYTHON_VERSION:S/thon//}.egg-info
> > (Mk/bsd.python.mk, around line 509)
> >
> > For Python versions, see PYTHON_VERSION, PYTHON_PORTVERSION and PYTHON_VER.
> > (Mk/bsd.python.mk, around line 372-410)
> >
> Okay, i will look there.
> 
> By the way, currently 'make fetch' does not work, because hosting site have
> broken certs. So, i was forced to do this:
> RUN_DEPENDS=    hg:${PORTSDIR}/devel/mercurial \
>                 wget:${PORTSDIR}/ftp/wget
> 
> FETCH_CMD=wget
> FETCH_BEFORE_ARGS=--no-check-certificate
> 
> Is it ok?

First, it should be FETCH_DEPENDS, not RUN_DEPENDS.

Back to the download problem, make fetch fails due to the default FETCH_ARGS (-AFpr).
-A flag denies "301/302 redirect" used by bitbucket.org to redirect requests to the destination.
It finally goes to cdn.bitbucket.org.
Therefore, you have two options:
1. Set MASTER_SITES=http://cdn.bitbucket.org/tortoisehg/targz/downloads/ to skip redirection.
2. Set FETCH_ARGS=-Fpr to allow redirect.
I prefer 1.

Detailed logs shown as follows:

% make fetch
=> tortoisehg-1.1.9.1.tar.gz doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch http://bitbucket.org/tortoisehg/targz/downloads//tortoisehg-1.1.9.1.tar.gz
looking up bitbucket.org
connecting to bitbucket.org:80
requesting http://bitbucket.org/tortoisehg/targz/downloads/tortoisehg-1.1.9.1.tar.gz
301 redirect to https://bitbucket.org/tortoisehg/targz/downloads/tortoisehg-1.1.9.1.tar.gz
looking up bitbucket.org
connecting to bitbucket.org:443
SSL connection established using DHE-RSA-AES256-SHA
Certificate subject: /C=NL/O=bitbucket.org/OU=GT16385137/OU=See www.geotrust.com/resources/cps (c)09/OU=Domain Control Validated - QuickSSL(R)/CN=bitbucket.org
Certificate issuer: /C=US/O=Equifax/OU=Equifax Secure Certificate Authority
requesting https://bitbucket.org/tortoisehg/targz/downloads/tortoisehg-1.1.9.1.tar.gz
302 redirect to http://cdn.bitbucket.org/tortoisehg/targz/downloads/tortoisehg-1.1.9.1.tar.gz
looking up cdn.bitbucket.org
connecting to cdn.bitbucket.org:80
requesting http://cdn.bitbucket.org/tortoisehg/targz/downloads/tortoisehg-1.1.9.1.tar.gz
remote size / mtime: 6815613 / 1296700276

Best regards,
-- 
   Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net> <sunpoet at FreeBSD.org>
           4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B
	                     http://people.FreeBSD.org/~sunpoet/pgpkeys.txt


More information about the freebsd-ports mailing list