Request for new port review: TortoiseHG.

[Sunpoet Hsieh]

Hi,

First of all, I suggest to set PORTNAME=tortoisehg
If you do want to add -hgtk suffix, you may set PKGNAMESUFFIX=-hgtk instead.
It makes portlint happier.
It also simplifies Makefile since DISTNAME is already the default value.

On Tue, Feb 8, 2011 at 7:40 PM, arrowdodger <6yearold at gmail.com> wrote:
> Hello. I've made a port for TortoiseHG (in fact, for its hgtk script). It is
> my first attempt in port creation, so i want someone to review it.
>
> The current problems are following:
> 1. The user can choose to not install nautilus extension and translation
> files (if defined(WITHOUT_NLS)). To prevent setup.py from installing those
> stuff, i've made two patches, that resides in ${FILESDIR}. They are
> generated from 'diff -u' and the problem is that they cannot be applied
> together. If i generate patches with simply 'diff', then everythink works,
> except that i should apply them manually (${PATCH} ${PYSETUP} <
> ${FILESDIR}/no-locale.patch).
> And what i've been told is that i should use EXTRA_PATCHES, insteand of
> invoking patch.
>

In your case, it can be done without extra patch files.

.if !defined(WITH_NAUTILUS)
        @${REINPLACE_CMD} -e '153,154 D' ${WRKSRC}/${PYSETUP}
.endif
.if !defined(WITH_NLS)
        @${REINPLACE_CMD} -e '150,152 D' ${WRKSRC}/${PYSETUP}
.endif

Here, I suggest a shorter option name "NAUTILUS" instead of
"NAUTILUS_EXTENSION".
Also, for PLIST_SUB, I think "NLS" is OK for most ports.

.if !defined(WITH_NLS)
PLIST_SUB+=     NLS="@comment "
.else
PLIST_SUB+=     NLS=""
.endif

> 2. The port also installs *.egg-info file and i'm not sure how to include it
> in the plist.

You should set PYDISTUTILS_EGGINFO=<egg-info files>.
bsd.python.mk will add them to PLIST automatically.

PYDISTUTILS_EGGINFO defaults to tortoisehg-1.1.9.1-py2.6.egg-info.
(when PORTNAME=tortoisehg)

> 3. The port also depends on py-gobject port, but there is no such value in
> USE_GNOME. I've already mentioned that on freebsd-gnome@ and they said, that
> it will be fixed after 8.2-RELEASE.
>
> You can obtain port from attachement or here:
> http://intara.org.ru/tortoisehg.tar.gz
>
> Thanks in advance.

Hope that helps.

Regards,
-- 
  Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net> <sunpoet at FreeBSD.org>
          4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B
                            http://people.FreeBSD.org/~sunpoet/pgpkeys.txt