How to escalate? ports/159276 - cmake

[Raphael Kubo da Costa]

Igor Soumenkov <2igosha at gmail.com> writes:

> The same effect can be achieved by specifying
> CMAKE_C(XX)_FLAGS_{RELEASE,DEBUG} in command line.
> So, I suggest removing the patch from
> ports/devel/cmake/files/patch-Modules_Compiler_GNU.cmake and patching
> ports/Mk/bsd.cmake.mk instead (attached). After applying this patch
> system C(XX)FLAGS will be propagated for Release and Debug build
> configurations.
>
> [...]
>
> --- ports/Mk/bsd.cmake.mk.original	2011-08-27 21:47:00.000000000 +0400
> +++ ports/Mk/bsd.cmake.mk	2011-08-27 22:43:46.000000000 +0400
> @@ -53,7 +53,11 @@
>  CMAKE_ARGS+=	-DCMAKE_C_COMPILER:STRING="${CC}" \
>  				-DCMAKE_CXX_COMPILER:STRING="${CXX}" \
>  				-DCMAKE_C_FLAGS:STRING="${CFLAGS}" \
> +				-DCMAKE_C_FLAGS_DEBUG:STRING="${CFLAGS}" \
> +				-DCMAKE_C_FLAGS_RELEASE:STRING="${CFLAGS}" \
>  				-DCMAKE_CXX_FLAGS:STRING="${CXXFLAGS}" \
> +				-DCMAKE_CXX_FLAGS_DEBUG:STRING="${CXXFLAGS}" \
> +				-DCMAKE_CXX_FLAGS_RELEASE:STRING="${CXXFLAGS}" \
>  				-DCMAKE_INSTALL_PREFIX:PATH="${CMAKE_INSTALL_PREFIX}" \
>  				-DCMAKE_BUILD_TYPE:STRING="${CMAKE_BUILD_TYPE}" \
>  				-DTHREADS_HAVE_PTHREAD_ARG:BOOL=YES

At first sight, the patch looks OK to me and solves the problem in a
cleaner way.

You could try submitting this patch to ports/159276. It might require an
exp-run, but I think it could get in.