XPI infrastructure needs some love

Lapo Luchini lapo at lapo.it
Tue Sep 7 20:55:30 UTC 2010

Philip M. Gollucci wrote:
> On 09/07/10 17:25, Philip M. Gollucci wrote:
>> On 09/07/10 16:39, Lapo Luchini wrote:
>>> Date       Number Description
>>> 2008/08/27 126876 Makefile.xpi's xpi-gen gets the wrong id sometimes
> This looks fine to me. Tests fine in tb.  make gen-xpi doesn't change
> XPI_ID for any ports either except for www/xpi-tambixplus below.

Right: I couple of my ports need that patch in order for xpi-gen to
generate the correct value, but I was manually changing the value before
port submit, so it doesn't change any actual committed data except that one.

>>> 2010/09/06 150327 [PATCH] Makefile.xpi: do not install XPI metadata
> Looks fine, but:
> 1) breaks PLIST for 8 other ports.  The fix is of course trivial

Yes, it avoids installing digital signature, so META-INF should be in
plist no more using that patch... OTOH as you correctly notice that
patch is using 'post-extract' target and some ports (that I didn't
notice) have one themselves; I'm not sure what's the correct approach to
have a default value in the include that doesn't conflict.

Lapo Luchini - http://lapo.it/

“C is quirky, flawed, and an enormous success.” (Dennis M. Ritchie)

More information about the freebsd-ports mailing list