MAKE_JOBS and openjdk6
naylor.b.david at gmail.com
Sun Sep 5 10:31:33 UTC 2010
On Saturday 04 September 2010 23:26:27 Greg Lewis wrote:
> On Sun, Aug 29, 2010 at 10:37:37AM +0200, David Naylor wrote:
> > On Saturday 28 August 2010 23:30:22 Greg Lewis wrote:
> > > On Sun, Aug 29, 2010 at 12:44:39AM +0400, Anonymous wrote:
> > > > Greg Lewis <glewis at eyesbeyond.com> writes:
> > Your attached patch does not explicitly define either MAKE_JOBS_(UN)SAFE.
> > I would by happy with it being defined as _UNSAFE. If there are no
> > other problems with your patch (see my comment at the bottom) then I'm
> > happy for this patch to be committed.
> I'd already committed a change that marked the port as MAKE_JOBS_UNSAFE, so
> the patch didn't include that.
Yes, sorry I didn't see that.
> > Is it safe to pass an empty HOTSPOT_BUILD_JOBS to MAKE_ENV? (i.e. when
> > DISABLE_MAKE_JOBS is defined.)
> Good thought. I tried the build with DISABLE_MAKE_JOBS set and experienced
> no problems, so I think we're ok on that front.
> > > > > +.endif
> > > > >
> > > > > COPYDIRS= \
> > > > >
> > > > > hotspot/src/os/linux/launcher \
> I'm going to commit the change in a day or two if there are no further
> objections. I'll then use it as a template for changes to the other JDK
No objections here. Thank you for your patience in resolving this.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 196 bytes
Desc: This is a digitally signed message part.
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20100905/08c03984/attachment.pgp
More information about the freebsd-ports