CFR: patch to cleanup usage of SRC_BASE in various ports

Ade Lovett ade at FreeBSD.org
Tue Nov 30 09:33:39 UTC 2010


On Nov 29, 2010, at 22:13 , Mark Linimon wrote:
> I would appreciate feedback on the following patch:
> 
>  http://people.freebsd.org/~linimon/patches/diff.out.srcbase

Seems like there's an awful lot of duplication of:

SRC_BASE?= /usr/src

in those port Makefiles.

What's wrong with adding the above, with a bit of documentation, to bsd.port.mk ?

This also allows portlint to be trivially extended to warn/fatal on seeing /usr/src in any port Makefile, pointing the author in the direction of ${SRC_BASE}

-aDe



More information about the freebsd-ports mailing list