PR's not being picked up (Was Re: becoming a port committor)
jhelfman at e-e.com
Tue Nov 23 03:42:32 UTC 2010
I put together this patch. I hope this is sufficient.
On Mon, Nov 22, 2010 at 07:58:56PM +0100, Torfinn Ingolfsen thus spake:
>On Mon, Nov 22, 2010 at 2:19 PM, RW <rwmaillists at googlemail.com> wrote:
>> Actually it does discuss the wording of the synopsis for both new and
>> updated ports which gives the impression that that that section covers
>> Furthermore the update chapter is at the opposite end of the
>> index under the single misleading word "Upgrading". There's no mention
>> of "submitting" which is what people will be looking for.
>> IMO chapter 10 should either be 3.7 or be merged into 3.6. If anything
>> deserves to be under "Quick Porting" it's this.
>So then we will see your PR for an update of that chapter in the Porter's
>Handbook in the next few days perhaps?
>> The trouble is that even when people do read handbooks from beginning
>> to end there are always sections that that they are likely to skip
>> until they need them, and this is one of them.
>The Porter's Handbook is not going to be improved unless the people who read
>it and have ideas for improvement do something about it.
>freebsd-ports at freebsd.org mailing list
>To unsubscribe, send any mail to "freebsd-ports-unsubscribe at freebsd.org"
-------------- next part --------------
--- porters-handbook/book.sgml 2010-11-22 18:56:43.000000000 -0800
+++ porters-handbook/book.sgml.my 2010-11-22 19:34:25.000000000 -0800
@@ -412,6 +412,22 @@
waiting to be committed to &os;</ulink>.</para>
+ <para>If you are contributing a patch for a port, please <emphasis>do not</emphasis>
+ submit a shar. The recommeded way for submission of a patch is by using a utility
+ called <command>/usr/bin/diff</command> which is included as part of the base &os;
+ distribution. To create a suitable <command>diff</command>, copy the file that
+ needs patching to <replaceable>something.orig</replaceable>. Save your changes to
+ <replaceable>something</replaceable> and then create your patch.</para>
+ <screen>&prompt.user; <userinput>/usr/bin/diff something.orig something > somthing.diff
+ <para>Please see the aforementioned step for submission of <replaceable>something.diff
+ </replaceable> to &os; for consideration by using the &man.send-pr.1; program.
<para>Once we have looked at your port, we will get back to you if necessary, and put
it in the tree. Your name will also appear in the list of
<ulink url="&url.articles.contributors;/contrib-additional.html">Additional FreeBSD Contributors</ulink>
More information about the freebsd-ports