Mk/bsd.command.mk: missing CSH tag
rfarmer at predatorlabs.net
Thu Nov 18 17:18:41 UTC 2010
On Thu, Nov 18, 2010 at 08:13, Eir Nym <eirnym at gmail.com> wrote:
> On 18 November 2010 19:08, Jason Helfman <jhelfman at e-e.com> wrote:
>> Wrote a quick patch:
>> --- bsd.commands.mk.orig 2010-11-18 08:05:47.000000000 -0800
>> +++ bsd.commands.mk 2010-11-18 08:06:17.000000000 -0800
>> @@ -76,6 +76,7 @@
>> SED?= /usr/bin/sed
>> SETENV?= /usr/bin/env
>> SH?= /bin/sh
>> +CSH?= /bin/csh
>> SORT?= /usr/bin/sort
>> STRIP_CMD?= /usr/bin/strip
>> # Command to run commands as privileged user
The patch should probably retain alphabetical order.
> Your patch should check if tcsh is in system. it is optional component.
Why? What do you suggest happens if it isn't found? Nothing will break
except stuff that uses the variable and it would use the variable
because it needs csh. It is part of the base system (/bin/csh and
/bin/tcsh) for all supported releases.
More information about the freebsd-ports