OPTIONS and dynamic PKGNAMPREFIX, e.g. {APACHE, PYTHON, ETC}_PKGNAMEPREFIX (Was: ports/148637 ...)

[Christopher Key]

  On 21/07/2010 21:34, Philip M. Gollucci wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 07/21/10 20:30, Christopher Key wrote:
>>   On 19/07/2010 21:05, Anonymous wrote:
>>> Christopher Key<cjk32 at cam.ac.uk>   writes:
>>>
>>>>    A crude survey shows several ports with this problem, listed below.
>>> ...
>>>> If you can suggest which is the
>>>> preferred solution, I'll put together a patch.
>>> I don't know what workaround is preferred but I'd suggest
>>> UNIQUENAME. It's easier to type and has same dependency on
>>> PKGNAMEPREFIX.
> The mod_* ports should not be py-* prefixed.
>
> If you're going to do it, they should he ap${APACHE_VERSION}- prefixed.
>
> Several ports show examples of this already.  Also, AP_FAST_BUILD does
> this for you.

Sorry, the attached should be a little more sane.  The reason that this 
needs to be done manually, and that ${APACHE_VERSION} or 
${APACHE_PKGNAMEPREFIX} can't be used is that the options are read 
before bsd.apache.mk is included.

Kind regards,

Christopher Key.
-------------- next part --------------
Index: audio/mpdbrowser/Makefile
===================================================================
RCS file: /home/ncvs/ports/audio/mpdbrowser/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- audio/mpdbrowser/Makefile	31 May 2010 01:57:29 -0000	1.5
+++ audio/mpdbrowser/Makefile	21 Jul 2010 21:47:52 -0000
@@ -28,6 +28,9 @@
 
 OPTIONS=		MPD	"Install Music Player Daemon" on
 
+# bypass infrastructure bug
+UNIQUENAME=	py-${PORTNAME}
+
 .include <bsd.port.pre.mk>
 
 .if defined (WITH_MPD)
Index: devel/py-gdata/Makefile
===================================================================
RCS file: /home/ncvs/ports/devel/py-gdata/Makefile,v
retrieving revision 1.24
diff -u -r1.24 Makefile
--- devel/py-gdata/Makefile	22 May 2010 15:49:30 -0000	1.24
+++ devel/py-gdata/Makefile	21 Jul 2010 21:47:52 -0000
@@ -25,6 +25,9 @@
 
 EXAMPLESDIR=	${PREFIX}/share/examples/py-${PORTNAME}
 
+# bypass infrastructure bug
+UNIQUENAME=	py-${PORTNAME}
+
 .include <bsd.port.pre.mk>
 
 .if ${PYTHON_REL} < 250
Index: devel/py-twisted/Makefile
===================================================================
RCS file: /home/ncvs/ports/devel/py-twisted/Makefile,v
retrieving revision 1.37
diff -u -r1.37 Makefile
--- devel/py-twisted/Makefile	7 Feb 2010 09:34:25 -0000	1.37
+++ devel/py-twisted/Makefile	21 Jul 2010 21:47:52 -0000
@@ -36,6 +36,9 @@
 do-install:
 	${DO_NADA}
 
+# bypass infrastructure bug
+UNIQUENAME=	py-${PORTNAME}
+
 .include <bsd.port.pre.mk>
 
 .if !defined(WITHOUT_CONCH)
Index: graphics/py-pycha/Makefile
===================================================================
RCS file: /home/ncvs/ports/graphics/py-pycha/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- graphics/py-pycha/Makefile	29 Mar 2010 08:36:05 -0000	1.4
+++ graphics/py-pycha/Makefile	21 Jul 2010 21:47:52 -0000
@@ -19,6 +19,9 @@
 
 OPTIONS=	CAIRO   "Add support for py-cairo" On
 
+# bypass infrastructure bug
+UNIQUENAME=	py-${PORTNAME}
+
 .include <bsd.port.pre.mk>
 
 .if !defined(WITHOUT_CAIRO)
Index: news/py-pynzb/Makefile
===================================================================
RCS file: /home/ncvs/ports/news/py-pynzb/Makefile,v
retrieving revision 1.2
diff -u -r1.2 Makefile
--- news/py-pynzb/Makefile	13 Jun 2010 12:41:32 -0000	1.2
+++ news/py-pynzb/Makefile	21 Jul 2010 21:47:52 -0000
@@ -22,6 +22,9 @@
 OPTIONS=	LXML		"Add support for py-lxml" Off \
 		ELEMENTTREE	"Add support for py-elementtree" Off
 
+# bypass infrastructure bug
+UNIQUENAME=	py-${PORTNAME}
+
 .include <bsd.port.pre.mk>
 
 .if !defined(WITHOUT_LXML)
Index: security/py-keyring/Makefile
===================================================================
RCS file: /home/ncvs/ports/security/py-keyring/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- security/py-keyring/Makefile	21 Nov 2009 15:48:35 -0000	1.3
+++ security/py-keyring/Makefile	21 Jul 2010 21:47:52 -0000
@@ -25,6 +25,9 @@
 OPTIONS=	GNOME_KEYRING "GNOME Keyring backend" Off \
 		KDE_KWALLET "KDE KWallet backend" Off
 
+# bypass infrastructure bug
+UNIQUENAME=	py-${PORTNAME}
+
 .include <bsd.port.pre.mk>
 
 .if defined(WITH_GNOME_KEYRING)
Index: www/mod_accounting/Makefile
===================================================================
RCS file: /home/ncvs/ports/www/mod_accounting/Makefile,v
retrieving revision 1.23
diff -u -r1.23 Makefile
--- www/mod_accounting/Makefile	7 Jun 2010 03:43:54 -0000	1.23
+++ www/mod_accounting/Makefile	21 Jul 2010 21:47:52 -0000
@@ -23,6 +23,9 @@
 USE_APACHE=	13
 MAKE_ARGS+=	APXS="${APXS}"
 
+# bypass infrastructure bug
+UNIQUENAME=	ap-${PORTNAME}
+
 .include <bsd.port.options.mk>
 
 .if defined(WIT_PGSQL)
Index: www/mod_dav/Makefile
===================================================================
RCS file: /home/ncvs/ports/www/mod_dav/Makefile,v
retrieving revision 1.24
diff -u -r1.24 Makefile
--- www/mod_dav/Makefile	25 May 2010 20:17:29 -0000	1.24
+++ www/mod_dav/Makefile	21 Jul 2010 21:47:52 -0000
@@ -39,6 +39,9 @@
 		--includedir=${LOCALBASE}/${APACHEINCLUDEDIR} \
 		--with-apxs=${APXS}
 
+# bypass infrastructure bug
+UNIQUENAME=	ap-${PORTNAME}
+
 .include <bsd.port.pre.mk>
 .if defined(WITHOUT_APACHE_EXPAT)
 CONFIGURE_ARGS+=	--with-expat=${LOCALBASE}
Index: www/mod_limitipconn/Makefile
===================================================================
RCS file: /home/ncvs/ports/www/mod_limitipconn/Makefile,v
retrieving revision 1.12
diff -u -r1.12 Makefile
--- www/mod_limitipconn/Makefile	25 May 2010 20:17:32 -0000	1.12
+++ www/mod_limitipconn/Makefile	21 Jul 2010 21:47:52 -0000
@@ -22,6 +22,9 @@
 
 OPTIONS=	FIXCOUNT "Patch dangling browser connections counting" Off
 
+# bypass infrastructure bug
+UNIQUENAME=	ap-${PORTNAME}
+
 .include <bsd.port.pre.mk>
 
 .if defined(WITH_FIXCOUNT)
Index: www/mod_musicindex/Makefile
===================================================================
RCS file: /home/ncvs/ports/www/mod_musicindex/Makefile,v
retrieving revision 1.28
diff -u -r1.28 Makefile
--- www/mod_musicindex/Makefile	6 Jun 2010 20:44:03 -0000	1.28
+++ www/mod_musicindex/Makefile	21 Jul 2010 21:47:52 -0000
@@ -35,6 +35,9 @@
 
 PORTDOCS=	README
 
+# bypass infrastructure bug
+UNIQUENAME=	ap-${PORTNAME}
+
 .include <bsd.port.options.mk>
 
 .if defined(WITHOUT_NLS)
Index: www/mod_security/Makefile
===================================================================
RCS file: /home/ncvs/ports/www/mod_security/Makefile,v
retrieving revision 1.41
diff -u -r1.41 Makefile
--- www/mod_security/Makefile	8 Jun 2010 21:58:58 -0000	1.41
+++ www/mod_security/Makefile	21 Jul 2010 21:47:52 -0000
@@ -40,6 +40,9 @@
 OPTIONS=	LUA "Embedded Lua language support" off \
 		MLOGC "Build ModSecurity Log Collector" off
 
+# bypass infrastructure bug
+UNIQUENAME=	ap-${PORTNAME}
+
 .include <bsd.port.pre.mk>
 
 .if !defined(SKIP_RULES)