[patch] Re: A few questions about bsd.port.mk
lists at eitanadler.com
Mon Dec 6 02:34:44 UTC 2010
On Thu, Dec 2, 2010 at 5:49 PM, Eitan Adler <lists at eitanadler.com> wrote:
> I noticed a line in bsd.port.mk "Kludge for pre-3.0 systems"
> # Kludge for pre-3.0 ystems
> MACHINE_ARCH?= i386
> According to cvs blame asami@ added both lines in revision 1.306 in 1999
> Furthermore in bsd.port.mk it says ports should test against ARCH and
> not MACHINE_ARCH
> but bsd.port.subdir.mk uses MACHINE_ARCH on line 209.
> bsd.gnustep.mk has a similar test for MACHINE_ARCH instead of ARCH on
> line 136 (r1.1 by dinoex)
> 1) Should the initial line be removed
> 2) Should bsd.port.subdir.mk be changed to use ARCH instead?
> 3) Should bsd.gnustep.mk be changed to use ARCH instead?
Here is a completely untested patch that makes the changes above.
Comments on both the patch and my questions are appreciated.
More information about the freebsd-ports