MAKE_JOBS and openjdk6

Anonymous swell.k at gmail.com
Sat Aug 28 20:45:56 UTC 2010


Greg Lewis <glewis at eyesbeyond.com> writes:

> I would argue that overriding a private variable is a hack (other ports
> doing it doesn't make it not a hack).

You could've spoke up in ports/148754 about your concern in order for
portmgr@ to notice. The PR strived to be less intrusive than divorcing
build jobs from make jobs. Besides, I think adding more clutter to
Makefiles defeats purpose of having stuff in bsd.port.mk.

> Alternative patch attached which seems to achieve the same result from
> my perspective without overriding _MAKE_JOBS.

Hardcoding kern.smp.cpus and ignoring MAKE_JOBS_SAFE/UNSAFE doesn't seem
like a less hacky solution. I'd argue that it's more confusing because
MAKE_JOBS_UNSAFE is not equal to DISABLE_MAKE_JOBS.

> Index: Makefile
> ===================================================================
> RCS file: /var/fcvs/ports/java/openjdk6/Makefile,v
> retrieving revision 1.28
> diff -u -r1.28 Makefile
> --- Makefile	15 Aug 2010 05:23:06 -0000	1.28
> +++ Makefile	28 Aug 2010 18:27:44 -0000
> @@ -147,8 +147,14 @@
>  USE_DISPLAY=	yes
>  .endif
 
> -BUILD_JOBS_NUMBER!=	${SYSCTL} -n kern.smp.cpus
> +.if !defined(DISABLE_MAKE_JOBS)
> +.if defined(MAKE_JOBS_NUMBER)
> +BUILD_JOBS_NUMBER=	${MAKE_JOBS_NUMBER}
> +.else
> +BUILD_JOBS_NUMBER=	`${SYSCTL} -n kern.smp.cpus`
> +.endif
>  MAKE_ENV+=	HOTSPOT_BUILD_JOBS=${BUILD_JOBS_NUMBER}
> +.endif
 
>  COPYDIRS=	\
>  	hotspot/src/os/linux/launcher \


More information about the freebsd-ports mailing list