NOPORTDOCS ignored on command line

[Greg Larkin]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Christian Weisgerber wrote:
> Wesley Shields:
> 
>> Are you seeing any particular problem on any particular port?
> 
> Yes, but I haven't committed it yet.
> 
>> wxs at rst wxs % cat Makefile 
>> all:
>> .if defined(NOPORTDOCS)
>> 	@echo "defined"
>> .else
>> 	@echo "not defined"
>> .endif
> 
> I have this:
> 
> .if !defined(NOPORTDOCS)
> INSTALL_TARGET= install install-dist_docDATA
> .endif
> 
> However, when I run "make -DNOPORTDOCS install", the install-dist_docDATA
> target is still executed!
> 
> So I have now added this snippet for debugging:
> 
> do-install:
>         @echo ${INSTALL_TARGET}; exit 1
> 
> $ make -DNOPORTDOCS -V INSTALL_TARGET
> install
> $ make -DNOPORTDOCS install
> ===>  Installing for xz-4.999.9
> ===>   Generating temporary packing list
> ===>  Checking if archivers/xz already installed
> ===>  Switching to root credentials for 'install' target
> install install-dist_docDATA
> *** Error code 1
> 
> Presumably bsd.port.mk invokes a recursive make for the install
> step, but fails to pass NOPORTDOCS.
> 

Hi Christian,

I handled the docDATA/NOPORTDOCS problem in the GraphicsMagick12 port
with the following excerpt from the Makefile:

.if defined(NOPORTDOCS)
# Get rid of the Makefile targets that install the documentation
# and HTML files into DOCSDIR
EXTRA_PATCHES+=	${FILESDIR}/extra-patch-Makefile.in
.endif

My files/extra-patch-Makefile.in contains:

- --- Makefile.in.orig	2008-11-19 17:40:16.000000000 -0500
+++ Makefile.in	2008-11-19 17:40:58.000000000 -0500
@@ -9322,7 +9322,7 @@
 info-am:

 install-data-am: install-codersLTLIBRARIES install-configlibDATA \
- -	install-configshareDATA install-data-local install-docDATA \
+	install-configshareDATA install-data-local \
 	install-filtersLTLIBRARIES install-includeHEADERS \
 	install-ltdlincludeHEADERS install-magickincHEADERS \
 	install-magickppincHEADERS install-magickpptopincHEADERS \
@@ -9671,8 +9671,7 @@
 	$(UTILITIES_INSTALL_EXEC_LOCAL_TARGETS)

 install-data-local: $(MAGICK_INSTALL_DATA_LOCAL_TARGETS) \
- -	$(PERLMAGICK_INSTALL_DATA_LOCAL_TARGETS) \
- -	$(HTML_INSTALL_DATA_TARGETS)
+	$(PERLMAGICK_INSTALL_DATA_LOCAL_TARGETS)

 uninstall-local: $(MAGICK_UNINSTALL_LOCAL_TARGETS) \
 	$(PERLMAGICK_UNINSTALL_LOCAL_TARGETS) \


There may be other ways to do it, but this worked well for me.

Hope it helps,
Greg
- --
Greg Larkin

http://www.FreeBSD.org/           - The Power To Serve
http://www.sourcehosting.net/     - Ready. Set. Code.
http://twitter.com/sourcehosting/ - Follow me, follow you
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iD8DBQFKsV9m0sRouByUApARAn7CAJ0et87tPmBI+8YPdCtAHhK4OYVS/ACcDQrm
byic5vM74Hn4z3DEkEr5e2g=
=b0JX
-----END PGP SIGNATURE-----