proftpd problems (ldap, quota, tds) and a patch

[Peter Czanik]

2009-10-15 04:30 keltezéssel, Wesley Shields írta:
> On Wed, Oct 14, 2009 at 09:42:49AM +0200, Peter Czanik wrote:
>   
>> Hello,
>>
>> I ran into a couple of problems with the proftpd port after the latest
>> update.
>>
>> Until now I compiled LDAP without the additional quota support. Now,
>> even if I select only "LDAP" in the config menu, I get:
>> ==> Configuring with mod_ldap:mod_tls:mod_quotatab_ldap                   
>> And compilation fails with ugly errors, unless I also select "quota" in
>> the config menu.
>>
>> The other problem is, that TDS is installed, even if it is not selected
>> in the config menu.
>>
>> The following fix is tested and works for me, even if not I'm not really
>> sure, if it is really correct. All the problematic config options seem
>> to work again as expected.
>>     
> I just committed a patch which fixes a lot of things that were wrong
> with that port. Please let me know if you continue to have problems with
> it.
>   
Quota handling is still wrong. In my case: if LDAP is enabled, then with
the current Makefile, mod_quotatab_ldap is enabled automagically, even
if quota is not enabled, which results in a build failure. Quota related
options should be enabled for ldap and sql only if quota is enabled. My
patch does exactly this.
Bye,
CzP

[root at v16 /usr/ports/ftp/proftpd]# diff -u Makefile.orig Makefile
--- Makefile.orig       2009-10-15 04:26:17.000000000 +0200
+++ Makefile    2009-10-16 16:05:37.000000000 +0200
@@ -233,8 +233,6 @@
 .if defined(WITH_QUOTA)
 MODULES:=${MODULES}:mod_quotatab:mod_quotatab_file
 QUOTA_SUB=     QUOTA=""
-.else
-QUOTA_SUB=     QUOTA="@comment "
 .if defined(WITH_LDAP)
 MODULES:=${MODULES}:mod_quotatab_ldap
 .endif
@@ -242,6 +240,8 @@
 MODULES:=${MODULES}:mod_quotatab_sql:mod_quotatab
 QUOTA_SUB=     QUOTA=""
 .endif
+.else
+QUOTA_SUB=     QUOTA="@comment "
 .endif

 PLIST_SUB+=    ${QUOTA_SUB}