MAKE_JOBS_UNSAFE (some more ports)

Maho NAKATA chat95 at mac.com
Tue May 26 08:51:50 UTC 2009


From: Pav Lucistnik <pav at FreeBSD.org>
Subject: Re: MAKE_JOBS_UNSAFE (some more ports)
Date: Tue, 26 May 2009 10:48:25 +0200

> David Naylor pí¹e v út 26. 05. 2009 v 08:19 +0200:
> 
>> pav: ${_MAKE_JOBS:C/-j//} won't work with DISABLE_MAKE_JOBS (or 
>> MAKE_JOBS_UNSAFE) since it needs to always be a positive number, secondly it 
>> still cannot be used for conditional code (since it is defined in the post 
>> section, but the whole code could always be moved to the pre section). 
> 
> I'm hesitant to modify bsd.port.mk for benefit of just four ports.
> Also, I think having MAKE_JOBS_NUMBER set to 1 when the feature is in
> fact disable, is counter-intuitive (because -j1 is very different to no
> -j at all).
> 
> So how about just having
> 
> .if defined(DISABLE_MAKE_JOBS)
> MAKE_JOBS_NUMBER=	1
> .else
> MAKE_JOBS_NUMBER!=	echo `${SYSCTL} -n kern.smp.cpus`
> .endif
> 
> in ooo makefile?

for me ok.
thank you
-- Nakata Maho http://accc.riken.jp/maho/ , http://ja.openoffice.org/ 
   Nakata Maho's PGP public keys: http://accc.riken.jp/maho/maho.pgp.txt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20090526/26e6bc6a/attachment.pgp


More information about the freebsd-ports mailing list