MAKE_JOBS_UNSAFE (some more ports)

[Pav Lucistnik]

Ion-Mihai Tetcu píše v ne 24. 05. 2009 v 19:01 +0300:
> On Sun, 24 May 2009 16:10:23 +0200
> Pav Lucistnik <pav at FreeBSD.org> wrote:
> 
> > Ion-Mihai Tetcu píše v so 23. 05. 2009 v 13:51 +0300:
> > 
> > > > > - MAKE_JOBS_NUMBER defaults (but user defined) to number of
> > > > > cores
> > > 
> > > This part looks OK, I wonder if there's any reason t ain't like this
> > > now; Pav?
> > > -.if defined(MAKE_JOBS_NUMBER)
> > > +MAKE_JOBS_NUMBER?=	`${SYSCTL} -n kern.smp.cpus`
> > >  _MAKE_JOBS=		-j${MAKE_JOBS_NUMBER}
> > > -.else
> > > -_MAKE_JOBS=		-j`${SYSCTL} -n kern.smp.cpus`
> > > -.endif
> > 
> > Wouldn't that mean an evaluation of the backtick command in every
> > make(1) invocation? That would be highly undesirable.
> 
> Umm, why? it shouldn't be evaluated if MAKE_JOBS_NUMBER is defined, no?
> Am I missing some make magic here?

But for 99.99% of the users, MAKE_JOBS_NUMBER is not defined.

-- 
Pav Lucistnik <pav at oook.cz>
              <pav at FreeBSD.org>
... the obese drugged penguin used by Linux. -- Scott Long
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?=
	=?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?=
	=?ISO-8859-1?Q?_zpr=E1vy?=
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20090524/6a93acf8/attachment.pgp