kipi-plugins-kde4 and digikam-kde4 picks up qt3 headers from qt-copy-3.3.8_9

[Goran Lowkrantz]

--On Wednesday, February 18, 2009 8:58 PM -0600 Matt <datahead4 at gmail.com> 
wrote:

> On Wed, Feb 18, 2009 at 4:34 PM, Goran Lowkrantz <glz at hidden-powers.com>
> wrote:
>> --On Wednesday, February 18, 2009 3:55 PM -0600 Matt
>> <datahead4 at gmail.com> wrote:
>>
> [snip]
>
>>>> [  9%] ^[[32mBuilding CXX object
>>>> digikam/CMakeFiles/digikamcore.dir/__/libs/threadimageio/loadsavetask.
>>>> o^M ^[[0mcd
>>>> /var/ports/usr/ports/graphics/digikam-kde4/work/digikam-0.10.0-rc2/dig
>>>> ik am && /usr/bin/c++   -D_GNU_SOURCE -DQT_NO_STL -D
>>>> QT_NO_CAST_TO_ASCII -D_REENTRANT -DKDE_DEPRECATED_WARNINGS
[snip]
>>>>               from /usr/local/include/qwidget.h:45,^M
>>>>               from /usr/local/include/qdesktopwidget.h:40,^M
>>>>
> [snip]
>>
>> Sorry, forgot the configure info:
>> --
>> ------------------------------------------------------------------------
>> ---------- --  digiKam 0.10.0-rc2 dependencies results
>> <http://www.digikam.org> --
>> --  Qt4 SQL module found................ YES
>> --  libjpeg library found............... YES
>> --  libtiff library found............... YES
>> --  libpng library found................ YES
>> --  libjasper library found............. YES
>> --  liblcms library found............... YES
>> --  libkipi library found............... YES
>> --  libkexiv2 library found............. YES
>> --  libkdcraw library found............. YES
>> --  libgphoto2 library found............ YES
>> --  libkdepimlibs library found......... YES (optional)
>> --  libmarblewidget library found....... YES (optional)
>> --  liblensfun library found............ NO  (optional)
>> --
>> --  digiKam will be compiled without lens auto-correction image editor
>> plugin.
>> --
>> --  digiKam will be compiled............ YES
>> --
>> ------------------------------------------------------------------------
>> ----------
>>
>> /glz
>
> Can you try the attached patch and see how it goes?  It's a simple
> change to the include line for the libs/threadimageio/loadsavetask.cpp
> file that will hopefully help get Qt3 out of the way.  I can't test it
> here since I'm not seeing the problem, but I can confirm that the port
> does build with the patch applied.
>
> Matt

Yes, we get past that one, next fail at
^[[0m[ 13%] ^[[32mBuilding CXX object 
digikam/CMakeFiles/digikamcore.dir/__/libs/widgets/common/histogramwidget.o^M
^[[0mIn file included from /usr/local/include/qpen.h:43,^M
                 from /usr/local/include/qpainter.h:47,^M
                 from 
/var/ports/usr/ports/graphics/digikam-kde4/work/digikam-0.10.0-rc2/libs/widgets/common/histogram
widget.cpp:37:^M
/usr/local/include/qshared.h:46: error: function definition does not 
declare parameters^M
In file included from /usr/local/include/qpainter.h:47,^M
                 from 
/var/ports/usr/ports/graphics/digikam-kde4/work/digikam-0.10.0-rc2/libs/widgets/common/histogram
widget.cpp:37:^M
/usr/local/include/qpen.h:47: error: function definition does not declare 
parameters^M
/usr/local/include/qpen.h:95: error: expected initializer before '&' token^M
/usr/local/include/qpen.h:96: error: expected initializer before '&' token^M
In file included from /usr/local/include/qmemarray.h:42,^M
                 from /usr/local/include/qpointarray.h:42,^M

which is fixed by changing to
#include <QPixmap>
#include <QPainter>
#include <QPen>
#include <QEvent>
#include <QTimer>
#include <QColor>
#include <QBrush>
#include <QRect>
#include <QFont>
#include <QFontMetrics>
#include <QToolTip>

but then the next file fails in the same way as the previous files, i.e. 
at3 includes.

Seems like a total switch to Qt4 include names would be in order.

/glz