Is postgresql83-server broken? (update: ICU and autotools problems?)

[Palle Girgensohn]

Mea culpa, I failed to committ the Makefile change last week. Now 
everything should work fine.

Regards,
Palle

--On måndag, må 1 sep 2008 13.45.32 +0200 Ivan Voras <ivoras at freebsd.org> 
wrote:

> 2008/9/1 Alex Goncharov <alex-goncharov at comcast.net>:
>> ,--- You/Ivan (Mon, 01 Sep 2008 11:29:39 +0200) ----*
>> | Can someone else confirm this? Do your postgresql83-server ports build?
>>
>> Builds for me:
>>
>
>> $ ls -l Makefile
>> -rw-r--r--  1 root  wheel  10599 Aug 26 06:53 Makefile
>>
>> $ md5 Makefile
>> MD5 (Makefile) = a2e5324a341aba72d86904c3f7453509
>>
>> --------------------
>>
>> What problem do you have?  With the same Makefile?
>
> Yes,  my Makefile is the same:
>
> /usr/ports/databases/postgresql83-server> md5 Makefile
> MD5 (Makefile) = a2e5324a341aba72d86904c3f7453509
>
> Are you using ICU?
>
> My (first) problem is this: distfile contains the following:
> MD5 (postgresql/pg-833-icu-xx-2008-08-28.diff.gz) =
> 94fb6634636cd36cb5fde449d76ece65
> SHA256 (postgresql/pg-833-icu-xx-2008-08-28.diff.gz) =
> c7d77dafe78afcf2e92567c7cdfda45dcfe41ea71efb2e326ef4f7eb66ec416b
> SIZE (postgresql/pg-833-icu-xx-2008-08-28.diff.gz) = 5302
>
> but the Makefile contains:
>
> .  if (defined(SERVER_ONLY) && defined(WITH_ICU)) || make(makesum)
> USE_AUTOTOOLS=  autoconf:262
> CONFIGURE_ARGS+=--with-icu
> LIB_DEPENDS=    icudata:${PORTSDIR}/devel/icu
> PATCH_SITES+=   http://people.freebsd.org/~girgen/postgresql-icu/:icu
> PATCHFILES+=    pg-833-icu-xx-2008-06-11.diff.gz:icu
> .  endif
>
> e.g. the ICU patches are mismatched:
>
># make
>
> ===>  Vulnerability check disabled, database not found
> ===>  Found saved configuration for postgresql-server-8.3.1
> ===>  Extracting for postgresql-server-8.3.3
> => MD5 Checksum OK for postgresql/postgresql-8.3.3.tar.bz2.
> => SHA256 Checksum OK for postgresql/postgresql-8.3.3.tar.bz2.
> => No MD5 checksum recorded for
> postgresql/pg-833-icu-xx-2008-06-11.diff.gz. => No SHA256 checksum
> recorded for postgresql/pg-833-icu-xx-2008-06-11.diff.gz. => No suitable
> checksum found for postgresql/pg-833-icu-xx-2008-06-11.diff.gz. *** Error
> code 1
>
> Stop in /usr/ports/databases/postgresql83-server.
> *** Error code 1
>
> Stop in /usr/ports/databases/postgresql83-server.
>
> ----
>
> After I fix this manually with "make makesum", there's another problem:
>
> ===>  Configuring for postgresql-server-8.3.3
> configure.in:22: error: Autoconf version 2.61 is required.
> Untested combinations of 'autoconf' and PostgreSQL versions are not
> recommended.  You can remove the check from 'configure.in' but it is then
> your responsibility whether the result works or not.
> configure.in:22: the top level
> autom4te-2.62: /usr/local/bin/gm4 failed with exit status: 1
> *** Error code 1
>
> Stop in /usr/ports/databases/postgresql83-server.
> *** Error code 1
>
> Stop in /usr/ports/databases/postgresql83-server.
>
> I believe this is also related to ICU because of this fragment in
> Makefile:
>
> .  if (defined(SERVER_ONLY) && defined(WITH_ICU)) || make(makesum)
> USE_AUTOTOOLS=  autoconf:262
> CONFIGURE_ARGS+=--with-icu
> LIB_DEPENDS=    icudata:${PORTSDIR}/devel/icu
> PATCH_SITES+=   http://people.freebsd.org/~girgen/postgresql-icu/:icu
> PATCHFILES+=    pg-833-icu-xx-2008-06-11.diff.gz:icu
> .  endif
>
> i.e. ICU is forcing autoconf 2.62 instead of 2.61. There is no
> autoconf 2.61 in ports. It is needed because configure.in needs to be
> patched for ICU. I think the ICU patch needs to be updated to the one
> I attached (or maybe the fixed ICU patches were mistakenly not
> committed before?)
>
> (ICU is needed to get working collations with UTF-8).