State of sysutils/lsof on RELENG_6

[Vic Abell]

Jeremy,

Thanks for your FYI.

An additional FYI is that I no longer support lsof on FreeBSD
systems where I can't test it.  I have access only to 4.9, 7.0
and 8.0, so lsof for FreeBSD 6.3 is unsupported, except in
special circumstances.

A special circumstance arose regarding 6.3 where the person
reporting a problem building lsof because of the locking
changes was willing to test for me and the lsof change was
minimal.  Hence I updated lsof's Configure script to propagate
the 7.0 and above lockf tests downward to 6.x.

There are two Q&A's in the lsof FAQ (the file 00FAQ in the
lsof distribution), which deal with lockf/if_* problems.  The
questions are:

  8.6   Why can't Configure create lsof_owner.h for FreeBSD 7 and above?
  8.6.1 Why are there lockf structure compiler errors for FreeBSD 7.0
        and higher lsof?

If anyone has suggestions on how to clarify the answers to those
questions, I would be happy to hear it.  For example, how does
one end up with an up-to-date /usr/src/sys/sys.lockf.h and an out-
of-date /usr/include/sys/lockf.h; and what does one do to bring the
two into sync?

Vic, lsof author


> -----Original Message-----
> From: Jeremy Chadwick [mailto:koitsu at FreeBSD.org] 
> Sent: Tuesday, May 20, 2008 12:14 PM
> To: freebsd-ports at FreeBSD.org
> Cc: abe at purdue.edu; ler at lerctr.org
> Subject: State of sysutils/lsof on RELENG_6
> 
> 
> This is more of a "FYI" mail than that of "it's broken! Fix it!".
> Chances are users will mail -ports about this eventually.
> 
> Today on EFNet #bsdports, it was mentioned that on a users' RELENG_6_3
> machine, sysutils/lsof wasn't building.  I tried the same on our
> RELENG_6 box (build date of January 14th -- yet /usr/src on that same
> box is csup'd daily) and received the semi-famous dnode.c 
> errors stating
> lf_flags was missing from the lockf struct.
> 
> Both systems above were attempting to build lsof 4.80, PORTEPOCH=2.
> 
> The issue appears to be caused by /usr/include/sys/lockf.h differing
> greatly from that of /usr/src/sys/sys/lockf.h on both systems.  Other
> users determined that a present-day RELENG_6 system (world built
> recently) worked fine, which makes sense based on the below.
> 
> The reason it's broken is due to MFC'd lockf changes in 
> RELENG_6, dated
> April 24th (see revision 1.18.2.2):
> 
> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/sys/lockf.h
> 
> I'd recommend adding an OSVERSION check to sysutils/lsof/Makefile,
> requesting the user update their system if older than April 24th.  But
> there doesn't appear to be an OSVERSION for this MFC that applies to
> 6.x.  There is one for 7.x (700108), but none for RELENG_6 that I can
> see.
> 
> http://www.freebsd.org/doc/en/books/porters-handbook/freebsd-v
ersions.html

Advice?

CC'ing Vic (purely as an information gesture), and port maintainer.

-- 
| Jeremy Chadwick                                jdc at parodius.com |
| Parodius Networking                       http://www.parodius.com/ |
| UNIX Systems Administrator                  Mountain View, CA, USA |
| Making life hard for others since 1977.              PGP: 4BD6C0CB |