patch for net-mgmt/zabbix

Dmitriy Kirhlarov dimma at higis.ru
Mon Mar 17 11:18:45 UTC 2008


Дмитрий Лоханский wrote:
> 
> There is  a path "patch-src__libs__zbxcomms__comms.c"
> 
> --- src/libs/zbxcomms/comms.c.orig      2008-03-15 07:23:00.000000000 +0300
> +++ src/libs/zbxcomms/comms.c   2008-03-15 07:24:09.000000000 +0300
> @@ -698,7 +698,7 @@
> 
>         for(i = 0; i < s->num_socks; i++) {
>  #if !defined(_WINDOWS)
> -               if(s->sockets[i] > n)
> +               if(s->sockets[i] + 1 > n)
>                         n = s->sockets[i] + 1;
>  #endif
>                 if(FD_ISSET(s->sockets[i], &sock_set))
> 
> 
> As I know, in select(ndfs, ...), ndfs must be max descriptor + 1.
> So, zabbix have a little bug, some connections in zbx_tcp_accept() will 
> be not accepted,
> because their socket descriptors are not in the ndfs.
> 
> This patch resolve troubles with "ZBX_TCP_READ() failed [Interrupted 
> system call]" issue
> from http://www.zabbix.com/forum/showthread.php?t=8870&mode=linear and 
> other related.

svn diff svn://svn.zabbix.com/tags/1.4.4/src/libs/zbxcomms/comms.c 
svn://svn.zabbix.com/branches/1.4/src/libs/zbxcomms/comms.c

1.4.4 already have your patch, but 1.4 brunch haven't.
Please, contact with developers over http://www.zabbix.com/forum

WBR.
Dmitriy



More information about the freebsd-ports mailing list