FreeBSD-games/Larn is broken in FreeBSD7.0 Release

[Martin Tournoij]

On Thu, Mar 06, 2008 at 09:00:53AM +0100, Edward Tomasz Napierala wrote:
> In article <op.t7ivojtk9aq2h7 at mezz.mezzweb.com> you wrote:
> >>>  When you run Larn, and chose to read/eat/drink anything the games exits
> >>>  with a signal 11 ,segfaults and does a coredump.
> >>>
> >>>  You have found a magic potion
> >>>  Do you (d) drink it, (t) take it, or (i) ignore it?
> >>>  Segmentation fault (core dumped) [SIGSEGV]drink
> >>>
> >>>  I would like to use Larn on 7.0, what do I suggest I do to fix this ?
> >>
> >> This is caused by the same problem as freebsd-games/hack.
> >> Please refer to the thread beginning with
> >> http://lists.freebsd.org/pipermail/freebsd-ports/2008-January/046245.html
> >>
> >> For the temporary solution,
> >> edit freebsd-games/files/patch-larn_Makefile to add -fwritable-strings
> >> to CFLAGS and do not forget to use gcc34 or earlier instead of gcc in  
> >> 7.0.
> >>
> >> Hope this helps.
> > 
> > I believe that someone in DragonFly BSD did a lot of clean up in the  
> > src/games/*. But I don't know if these cleans up will helping with this  
> > issue. It might be worth for someone to dig in there and bring in FreeBSD  
> > if someone care about these games.
> 
> Diff between freebsd-games and DragonFly, after removing irrelevant stuff,
> is over a megabyte long.  Maybe we should just use their code verbatim?
> 
> (Untested diff at http://freebsd.org/~trasz/patch-zzz_fixes_from_dfly)
> 

Good idea,

I tested the games from DragonflyBSD and they seem to work OK on
FreeBSD 7/GCC4.2

Everything compiles with some minor changes, the two issues with larn
and hack are solved, I didn't test any of the other games yet.

I need to do some more cleanup/testing, I will send a PR tomorrow
since it's very late now ...

Regards,
Martin Tournoij