INDEX build optimizations - please review

[Jeremy Messenger]

On Tue, 10 Jun 2008 11:45:32 -0500, Kris Kennaway <kris at FreeBSD.org> wrote:

> Another important optimization is to use /rescue/sh instead of /bin/sh  
> for index builds.  The former is statically linked and this is much  
> faster to execute.

I don't have INDEX in all of my systems, so I am only take a peek. What  
about users that have WITHOUT_RESCUE defined or/and something different?  
IMO, I think your patch should have a check on if /rescue/sh exists when  
our src provides optional of WITHOUT_RESCUE and is harmless to kill the  
/rescue.

------------------------------
.if exists(/rescue/sh)
__MAKE_SHELL=/rescue/sh
.else
__MAKE_SHELL=/bin/sh
.endif
------------------------------

Thanks for hint on 'NOTE TO PORT DEVELOPERS' part as I didn't know about  
VARIABLE!= vs $(${VARIABLE_CMDS}). /me copies it in my note.


--


As for the audio/festvox-hvs issue, probably because of no executables or  
files in RUN_DEPENDS:

------------------------------
RUN_DEPENDS=	${PORTSDIR}/audio/festival+OGI \
		${PORTSDIR}/audio/festlex-poslex \
		${PORTSDIR}/audio/festlex-ogi \
		${PORTSDIR}/audio/festogi-spanish
------------------------------

Cheers,
Mezz


-- 
mezz7 at cox.net  -  mezz at FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/  -  gnome at FreeBSD.org