[PATCH] portmaster with SU_CMD

[Jeremy Messenger]

On Fri, 04 Jan 2008 08:47:35 -0600, Stefan Sperling <stsp at stsp.name> wrote:

> On Thu, Jan 03, 2008 at 11:09:06PM -0600, Jeremy Messenger wrote:
>> On Thu, 03 Jan 2008 19:46:49 -0600, Jo Rhett <jrhett at svcolo.com> wrote:
>>
>>> On Nov 12, 2007, at 8:33 AM, Jeremy Messenger wrote:
>>>> I agree, because you can't build any ports in /usr/ports as in normal
>>>> user anyway. I don't see any good reason to do it either.
>>>
>>> Huh?  In 5 years of using FreeBSD I've never built a single port as  
>>> root.
>>> What are you talking about?
>>
>> You can't by default in /usr/ports.
>
> Mezz, I still don't see what default behaviour has got to do with  
> anything.
>
> By default you build ports as root.
> By default portmaster builds as root (even with the SU_CMD patch).
>
> So what? By default root also uses csh (barf), and by default
> the FreeBSD kernel contains several binary blobs.
>
> I'm not OK with any of these, but I can change my system accordingly.
>
> It's all a matter of personal judgement and taste, nothing else.
>
>> mezz7 at cox.net  -  mezz at FreeBSD.org
>> FreeBSD GNOME Team
>
> I'd like to point out that I have found two problems in gnome-related
> ports in FreeBSD since I've been using my patch, both of them failed
> to build as root:
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/117976
> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/118999
>
> And both have been fixed, and you even comitted the fix for PR #117976
> yourself.

Yes, I did.

> So obviously building as non-root isn't illegal nor is it discouraged.
> There is infrastructure in place to facilitate building as non-root
> in the ports system already, and all the patch does is add support for
> that infrastructure to portmaster.

It's not illegal. But add function in portmaster just doesn't make any  
sense, what portmaster does is to build, install and clean in loop.

> Whether Doug wants to maintain the patch in his tree is another question
> that is up for himself to decide on.

Sure, I am not forcing him. I am merely just add my option, so your too.

> But what has default behaviour of the system got to do with any of this?

The default always does matter. Someone set the default is because they  
work best.

Cheers,
Mezz


-- 
mezz7 at cox.net  -  mezz at FreeBSD.org
FreeBSD GNOME Team  -  FreeBSD Multimedia Hat (ports, not src)
http://www.FreeBSD.org/gnome/  -  gnome at FreeBSD.org
http://wiki.freebsd.org/multimedia  -  multimedia at FreeBSD.org