proposal: add --disable-tests to www/firefox3 port

Eitan Adler eitanadlerlist at gmail.com
Wed Dec 24 00:09:42 UTC 2008


>> Perhaps this could be part of the WITH_DEBUG option?
Like this?
--- firefox3/Makefile	2008-12-19 15:13:01.000000000 -0500
+++ firefox-new/Makefile	2008-12-23 19:07:09.000000000 -0500
@@ -57,6 +57,10 @@

 .include <bsd.port.pre.mk>

+.if defined(WITHOUT_DEBUG)
+MOZ_OPTIONS+=     --disable-tests
+.endif
+
 GECKO_PTHREAD_LIBS!=${CC} -dumpspecs | ${GREP} -m 1 '%{\!pg:
%{pthread:' | ${SED} -e 's|^.*%{\!pg: %{pthread:|| ; s|}.*$$||' || ${TRUE}

Also
WARN: Makefile: [SMB is listed in OPTIONS, but neither WITH_SMB nor
WITHOUT_SMB appears.]:
WARN: Makefile: [LOGGING is listed in OPTIONS, but neither WITH_LOGGING
nor WITHOUT_LOGGING appears.]:
WARN: Makefile: [OPTIMIZED_CFLAGS is listed in OPTIONS, but neither
WITH_OPTIMIZED_CFLAGS nor WITHOUT_OPTIMIZED_CFLAGS appears.]:

Are they used at all? should they just be removed?

-- 
Eitan Adler
GNU Key fingerprint: 2E13 BC16 5F54 0FBD 62ED 42B6 B65F 24AB E9C2 CCD1


More information about the freebsd-ports mailing list