bsd.sites.mk changes (was Re: Xfce goodies master sites)

[Warren Block]

The questions: is this the right thing to do and is it the right way to 
go about it?

If bsd.sites.mk is changed as shown below, all of the xfce "goodies" 
ports can use

   MASTER_SITES=   ${MASTER_SITE_XFCE_GOODIES}

That will unify all of the goodies ports and ease future changes like 
additional mirrors or moves.

There are currently 26 ports of xfce goodies (not counting the 
xfce-notification-daemon port, which I haven't submitted yet):

  #find /usr/ports -name Makefile -exec grep -l goodies.xfce.org {} \+

Proposed changes to bsd.sites.mk:

--- bsd.sites.mk.orig   2007-10-30 16:58:47.000000000 -0600
+++ bsd.sites.mk        2007-10-31 18:43:01.000000000 -0600
@@ -1359,6 +1359,11 @@
         http://www.p0llux.be/xfce/%SUBDIR%/src/
  .endif

+.if !defined(IGNORE_MASTER_SITE_XFCE_GOODIES)
+MASTER_SITE_XFCE_GOODIES+= \
+       http://goodies.xfce.org/releases/${PORTNAME}/
+.endif
+
  .if !defined(IGNORE_MASTER_SITE_XFREE)
  MASTER_SITE_XFREE+= \
         http://www.gtlib.cc.gatech.edu/pub/XFree86/%SUBDIR%/source/ \

-Warren Block * Rapid City, South Dakota USA