portmaster 1.24 broken for default port upgrades

John Marshall John.Marshall at riverwillow.com.au
Tue Oct 30 18:22:12 PDT 2007


I hate to do this to you but...

I upgraded to portmaster 1.24 and then tried to upgrade another port...

===>>> dovecot-1.0.6 is not depended on by any other ports
===>>> Creating a backup package for old version dovecot-1.0.6
         ===>>> Package can be found in /data/packages/All
If you do not intend to reinstall Dovecot, you should manually remove 
the user 'dovecot' (uid='143') and the group 'dovecot' (gid='143').
Cleaning up "/var/run/dovecot".
make: don't know how to make install. Stop

===>>> A backup package for mail/dovecot should be located in 

===>>> Installation of new port failed
===>>> Aborting update

I verified this on another system with another port. Installing a new 
port worked fine. Upgrading the newly-installed port resulted in the 
"make" error.

It looks like you accidentally lost the necessary belts-and-braces "In 
case we went elsewhere" line in your 1.23/1.24 transition (diff output 
culled to show only the relevant hunk)...

RCS file: /freebsd/ncvs/ports/ports-mgmt/portmaster/files/portmaster.sh.in,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- portmaster.sh.in 2007/10/21 05:33:07        1.23
+++ portmaster.sh.in 2007/10/30 07:18:50        1.24
@@ -1754,15 +1767,10 @@

-if [ -z "$RECURSE_THOROUGH" -a ! -e "$NO_DEP_UPDATES" ]; then
-       echo "===>>> Starting check for runtime dependencies"
-       dependency_check run-depends-list
-# In case we went elsewhere in the dependency check
-cd $pd/$portdir
-make $PM_MAKE_ARGS install || {
+# Do the install here in case a run dependency has a build dependency 
on us.
+# Defining NO_DEPENDS ensures that we will control the installation of the
+# run depends, not bsd.port.mk.
+make -DNO_DEPENDS $PM_MAKE_ARGS install || {
      if [ -z "$NO_BACKUP" -a -n "$upg_port" ]; then
         echo ''
         echo "===>>> A backup package for $portdir should be located in 

John Marshall

More information about the freebsd-ports mailing list