Error code 1 when upgrading ftp-proxy port

[Christian Ludwig]

On Sunday, 30.09.2007, 17:30 +0200 lists at socruel.nu wrote:
> root at host /root # cd /usr/ports/ftp/ftp-proxy/
> root at host ftp-proxy # make
> ===>  Vulnerability check disabled, database not found
> ===>  Extracting for ftp-proxy-4.1p2_1
> => MD5 Checksum OK for ftp-proxy-4.1p2.tar.gz.
> => SHA256 Checksum OK for ftp-proxy-4.1p2.tar.gz.
> ===>  Patching for ftp-proxy-4.1p2_1
> ===>   ftp-proxy-4.1p2_1 depends on shared library: event-1.3d - found
> ===>  Configuring for ftp-proxy-4.1p2_1
> ===>  Building for ftp-proxy-4.1p2_1
> Warning: Object directory not changed from original
> /usr/ports/ftp/ftp-proxy/work/ftp-proxy-4.1p2
> cc -O -pipe  -I/usr/ports/ftp/ftp-proxy/work/ftp-proxy-4.1p2 -Wall
> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith 
> -Wno-uninitialized  -c ftp-proxy.c
> ftp-proxy.c:32:19: event.h: No such file or directory

The problem is definitely that the port does not find the file "event.h"
for compilation. All the following errors are just related to this.

> I looked up the Makefile in work/ftp-proxy-4.1p2 and saw
> 
> CFLAGS+= -I${.CURDIR}
> CFLAGS+= -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith \
>          -Wno-uninitialized
> LDADD+= -levent -L${PREFIX}/lib
> DPADD+= ${LIBEVENT}
> 
> which means that /usr/local/include is not referenced in CFLAGS as is
> mentioned in the Makefile of the port. After linking
> /usr/local/include/event.h to work/ftp-proxy-4.1p2/event.h all is OK!

It is right, that CFLAGS does not contain -I${PREFIX}/include, because
that is specified in the port's Makefile.  The "+=" in both files makes
it both being used. You can see in your complation output that this does
not work in your setup:

> cc -O -pipe  -I/usr/ports/ftp/ftp-proxy/work/ftp-proxy-4.1p2 -Wall
> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith 
> -Wno-uninitialized  -c ftp-proxy.c

When I compile ftp-proxy from ports, I get the following output:

host# cd usr/ports/ftp/ftp-proxy
host# make
===>  Vulnerability check disabled, database not found
===>  Extracting for ftp-proxy-4.1p2_1
=> MD5 Checksum OK for ftp-proxy-4.1p2.tar.gz.
=> SHA256 Checksum OK for ftp-proxy-4.1p2.tar.gz.
===>  Patching for ftp-proxy-4.1p2_1
===>   ftp-proxy-4.1p2_1 depends on shared library: event-1.3d - found
===>  Configuring for ftp-proxy-4.1p2_1
===>  Building for ftp-proxy-4.1p2_1
Warning: Object directory not changed from
original /usr/ports/ftp/ftp-proxy/work/ftp-proxy-4.1p2
cc -O2 -fno-strict-aliasing -pipe  -I/usr/local/include
-I/usr/ports/ftp/ftp-proxy/work/ftp-proxy-4.1p2 -Wall
-Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith
-Wno-uninitialized  -c ftp-proxy.c
cc -O2 -fno-strict-aliasing -pipe  -I/usr/local/include
-I/usr/ports/ftp/ftp-proxy/work/ftp-proxy-4.1p2 -Wall
-Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith
-Wno-uninitialized  -c filter.c
cc -O2 -fno-strict-aliasing -pipe  -I/usr/local/include
-I/usr/ports/ftp/ftp-proxy/work/ftp-proxy-4.1p2 -Wall
-Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith
-Wno-uninitialized   -o ftp-proxy ftp-proxy.o filter.o -levent
-L/usr/local/lib
gzip -cn ftp-proxy.8 > ftp-proxy.8.gz
host# 

So in my setup the CFLAGS from the port's Makefile get honored.

Is this port the only one which has that problem? Seems like a bigger
issue on your side.


 - Christian