New port - please review
Tom McLaughlin
tmclaugh at sdf.lonestar.org
Mon Mar 26 02:52:38 UTC 2007
On Sat, 2007-03-24 at 20:50 +0100, Marcin Simonides wrote:
> I've made a port for gnome-subtitles, a subtitle editor with video
> preview (http://gnome-subtitles.sourceforge.net/).
>
> Since this is my first port I'd like to ask you to review and test it
> before I submit it.
>
Looks good, just a few changes.
- change HAS_CONFIGURE to GNU_CONFIGURE
- remove the DISTNAME line since it's not needed
- add gnomeprefix to the USE_GNOME line so it installs correctly within
the Gnome hierarchy. That'll affect the pkg-plist. The two files
installed under share/ should then be installed under share/gnome/
- The two patch files should be named:
patch-src_GnomeSubtitles_Execution_Executable.cs
patch-src_GnomeSubtitles_Execution_gnome-subtitles.in
to reflect the path to the files within the distfile.
Just shar the port up
(http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-submitting.html)
and send-pr it. CC. tmclaugh at FreeBSD.org on the PR and I'll take care
of it.
tom
> The file may be downloaded here:
> http://marcin.studio4plus.com/files/gnome-subtitles-port.tgz
> Just untar it in /usr/ports, multimedia/gnome-subtitles will be created.
>
> It requires (quoting the website):
>
> Mono >= 1.1 (mono to run, gmcs to build)
> Gtk-Sharp >= 2.8
> Glade-Sharp >= 2.8
> Gnome-Sharp >= 2.8
> Gtk+ >= 2.8
>
> and optionally mplayer. I hope that adding only the highest-level
> dependencies (eg. no gtk, since it is required by gtk-sharp) is enough.
>
> It works fine on my system (6.2-stable) but package registration takes a
> very long time. Is it normal (there is a lot of gnome dependencies to
> register, I think) or is something wrong?
>
> Thanks in advance!
--
| tmclaugh at sdf.lonestar.org tmclaugh at FreeBSD.org |
| FreeBSD http://www.FreeBSD.org |
| BSD# http://www.mono-project.com/Mono:FreeBSD |
More information about the freebsd-ports
mailing list