Ports 104877 causing big problems

[Ade Lovett]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On Mar 10, 2007, at 05:45 , Jean-Yves Lefort wrote:
> Repeatedly read the PR until you understand it. Pay attention to the
> provided objdump diff, and to the fact that the patch modifies the
> link_all_deplibs variable. Understand what that variable
> does. Understand why it should be set to "no" rather than to
> "unknown".

There is no empirical evidence in the PR.

Statement #1: "This slows down the linking considerably"
This one should be easy enough to prove.  Providing timings.  Pay  
particular attention to the relative timing of the final link-loader  
step compared with the time taken to register all dependencies as  
part of the pkg_install process.

Statement #2: "... creates a direct dependency between a library down  
the tree and a leaf program"
Incorrect.  Take three libraries; A, B, and C.  A depends on B.  B  
depends on C.  In order to ensure deterministic behavior in the event  
of 'C' being upgraded, *all* ports depending on it should also be  
rebuilt.  Thus, if something relatively low level like libpng is  
updated, then to guarantee at least deterministic failure modes,  
everything that depends on libpng should also be rebuilt (either  
manually, or via portupgrade/portmaster, both of which have flags to  
make this an easy process).

Statement #3: "The attached patch fixes the problem."
Unknown.  There are no comparative timings for the link-loader stage  
(statement 1), and merely obfuscates the dependency issue (statement  
2), particularly given that there are *two* dependency chains being  
discussed, the one inherent to .la files, and the one provided by the  
pkg_* tools.

> You managed to introduce this regression in one go with your .la
> resurrection.

Again, empirical evidence, please.  Cold, hard, facts, preferably  
without the negative emotions.  ports/94826 may be educational with  
regards to a possible approach.

- -aDe

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFF8sPYpXS8U0IvffwRAnRaAJ4oJUZ+PCoy/7cBqwxmGszNEgFrRwCdGugN
5iEjVNjrxg7Iwng32aGPyE4=
=LSgp
-----END PGP SIGNATURE-----