How do you remove unneeded patch files?
stephen at math.missouri.edu
Wed Jul 25 05:43:01 UTC 2007
Erwin Lansing wrote:
> On Tue, Jul 24, 2007 at 02:41:04PM -0500, Paul Schmehl wrote:
>> I'm working on a port upgrade. The existing port has a number of patch
>> files in FILESDIR that are no longer needed. (The changes they made have
>> been incorporated into the distro.) What's the appropriate way to submit
>> those changes? Normally, a send-pr submission will contain the patches for
>> existing port files. There is no patch for these. They need to be removed.
>> I could do this: diff -Naur files/original_patch_file files/empty_file, but
>> I don't know if that removes the file or simply replaces it with an empty
> The result of using that patch would be an empty file. This is also
> alright to submit it that way, but as a courtesy to the committer (and
> also to make sure he doesn't forget) it would be good to mention in the
> PR that file/xyz and files/abc should be removed completely.
You really should be unambiguous and clear in explaining that the files
are to be deleted. I have had a couple of experiences where ports I
maintain did not have the files deleted, and I had to remind the committer.
More information about the freebsd-ports