sysutils/libutempter broken: no logins/logouts are recorded

[Andriy Gapon]

This is from ktrace of xterm:
$ fgrep -B1 -A2 utemp kdump.out
 24690 xterm    CALL  execve(0x801679faf,0x7fffffffd5e0,0x7fffffffe540)
 24690 xterm    NAMI  "/libexec/utempter/utempter"
 24690 xterm    RET   execve -1 errno 2 No such file or directory
 24690 xterm    CALL  exit(0x1)


This is from libutempter compilation:
cc -O2 -fno-strict-aliasing -pipe -O2 -fno-strict-aliasing -pipe
-march=athlon64 -DLIBEXECDIR=\"/usr/local/libexec\" -std=gnu99 -W -Wall
-Waggregate-return -Wcast-align -Wconversion -Wdisabled-optimization
-Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn
-Wmissing-prototypes -Wpointer-arith -Wredundant-decls -Wshadow
-Wstrict-prototypes -Wwrite-strings -DLIBEXECDIR=\"/libexec\"  -c -o
utempter.o utempter.c
<command line>:3:1: warning: "LIBEXECDIR" redefined
<command line>:2:1: warning: this is the location of the previous definition

As you can see LIBEXECDIR is defined twice on command line and the
incorrect definition gets actually used.

I think that the patch to Makefile (files/patch-Makefile) is
incorrect/incomplete: it adds correct definition to CFLAGS but doesn't
fix CPPFLAGS with incorrect definition.

Should I rather open a PR about this ?

P.S. also 'make reinstall FORCE_PKG_REGISTER=1' fails for this port
because a symlink to the shared library is created with 'ln -s'. I think
'-f' would be useful here too.

-- 
Andriy Gapon