My First Port
shaun at FreeBSD.org
Tue Jul 3 20:21:46 UTC 2007
On Tue, Jul 03, 2007 at 02:28:34PM -0400, Michael W. Lucas wrote:
> I would appreciate any comments, critiques, etc., before I submit
> this. (Or, if you ports guys would rather I submit it as-is and then
> tell me all the things I did wrong, I'm OK with that too.) While I'm
> not a ports guy, I'm willing to try to maintain this.
A few minor observations:
1) You're missing the standard header block.
2) There's a trailing space on the COMMENT line.
3) Instead of setting EXTRACT_SUFX, we have a special variable for bzip2
Otherwise, it looks good.
Shaun Amott // PGP: 0x6B387A9A
"A foolish consistency is the hobgoblin
of little minds." - Ralph Waldo Emerson
More information about the freebsd-ports