FreeBSD Port: amanda-client-2.5.1p3,1
kuriyama at imgsrc.co.jp
Thu Feb 15 02:36:13 UTC 2007
At Wed, 14 Feb 2007 08:54:47 -0600,
Craig Boston wrote:
> It looks like the code in sendsize.c that generates the dump arguments
> was completely rewritten between p2 and p3, and a mistake was made
> (PARAM_DUMP_ESTIMATE used twice instead of PARAM_HONOR_NODUMP). A patch
> is attached that should fix it.
> We can add the patch to ports if necessary, but as the problem exists in
> upstream sources it should really be fixed there.
> > I cannot say if the same problem exists in sendbackup. My dumps didn't
> > make it that far :(
> Glancing through sendbackup-dump.c it looks like everything should be
> fine there (though I'm actually a little surprised that the -L patch
> still applies cleanly). I haven't run a backup with the fixed sendsize
> yet, however, so I guess we'll see.
> [2 sendsize.patch <text/x-diff; us-ascii (7bit)>]
> --- client-src/sendsize.c.orig Wed Feb 14 08:47:15 2007
> +++ client-src/sendsize.c Wed Feb 14 08:45:10 2007
> @@ -1190,7 +1190,7 @@
> # endif
> dumpkeys = vstralloc(level_str,
> - PARAM_DUMP_ESTIMATE,
> + PARAM_HONOR_NODUMP,
> "s", "f", NULL);
> # ifdef HAVE_DUMP_ESTIMATE
Thank you for your investigation. I've committed your patch into our
Jun Kuriyama <kuriyama at imgsrc.co.jp> // IMG SRC, Inc.
<kuriyama at FreeBSD.org> // FreeBSD Project
More information about the freebsd-ports